Skip to content

Apply the coloured Bash profile to native Server terminals - #115

Merged
stevejuma merged 2 commits into
mainfrom
fix/server-native-terminal-profile
Nov 20, 2026
Merged

stevejuma merged 2 commits into
mainfrom
fix/server-native-terminal-profile

Conversation

@stevejuma

@stevejuma stevejuma commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Server v2.5.1 shipped the terminal font, renderer and session UI, but the coloured prompt and listings existed only in Storybook fixtures. Apply the profile to real native Server shells: cyan paths, a magenta eight-character managed vault UUID, green/red command status and coloured ls. Actual cwd and pwd retain full paths.

Server supplies its launch policy through a generic Core shell factory. Login-interactive Bash loads normal startup files once, preserves scalar/array prompt hooks and handles path text as data. Private hooks stay out of nested shells. LAPIS_SERVER_TERMINAL_PROFILE=0 restores the original login shell. Desktop is unchanged.

Consumes merged lapismd/terminal-host#5, pinned to its tested source revision 88fae24eb24934bb8dcc8bdf2eb0f1e86ffb39ef. The PTY crate remains private and unpublished. Includes a Server patch changeset and canonical application evidence.

Validation:

  • Original real-Host regression: one failure before implementation, passing now through configured and profile-backed startup with the setting unset.
  • Seven real-PTY profile cases pass on Bash 3.2 and 5.3: ANSI prompts/listings, startup/hooks/status, full paths, malicious cwd text, foreign UUIDs, opt-out and nested shells.
  • Core/Server: 877 passed, zero failed, 11 existing ignored cases/helpers. Direct protocol/CLI/Content HTTP/MCP suites: 95 passed, zero failed. Strict Clippy and native builds pass for all six packages.
  • Frozen registry install, web check, 227 unit tests, web build, 92 Storybook interaction/accessibility cases, static Storybook build and five static tests pass.
  • Specification, formatting and new Rust-file formatting checks pass. The existing macOS native linker warning remains.

Docker-image verification is excluded at the user's request. This PR does not claim the native profile is already released in 350d8e7-slim.

The Linux CI prompt assertion now distinguishes visible ANSI text from OSC cwd metadata. A real startup-hook fixture reproduces the initial failure; the exact visible prompt must match the compact coloured path while hidden metadata retains the full physical cwd. All seven profile cases pass on Bash 3.2/5.3, and the complete Server suite passes 198 cases with zero failures and one existing SSH opt-in. Runtime code is unchanged by this test correction.

@stevejuma
stevejuma enabled auto-merge (squash) November 20, 2026 16:17
@stevejuma
stevejuma merged commit d8556bb into main Nov 20, 2026
10 checks passed
@stevejuma
stevejuma deleted the fix/server-native-terminal-profile branch November 20, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant