Repository navigation
Apply the coloured Bash profile to native Server terminals - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server v2.5.1 shipped the terminal font, renderer and session UI, but the coloured prompt and listings existed only in Storybook fixtures. Apply the profile to real native Server shells: cyan paths, a magenta eight-character managed vault UUID, green/red command status and coloured
ls. Actual cwd andpwdretain full paths.Server supplies its launch policy through a generic Core shell factory. Login-interactive Bash loads normal startup files once, preserves scalar/array prompt hooks and handles path text as data. Private hooks stay out of nested shells.
LAPIS_SERVER_TERMINAL_PROFILE=0restores the original login shell. Desktop is unchanged.Consumes merged lapismd/terminal-host#5, pinned to its tested source revision
88fae24eb24934bb8dcc8bdf2eb0f1e86ffb39ef. The PTY crate remains private and unpublished. Includes a Server patch changeset and canonical application evidence.Validation:
Docker-image verification is excluded at the user's request. This PR does not claim the native profile is already released in
350d8e7-slim.The Linux CI prompt assertion now distinguishes visible ANSI text from OSC cwd metadata. A real startup-hook fixture reproduces the initial failure; the exact visible prompt must match the compact coloured path while hidden metadata retains the full physical cwd. All seven profile cases pass on Bash 3.2/5.3, and the complete Server suite passes 198 cases with zero failures and one existing SSH opt-in. Runtime code is unchanged by this test correction.