Skip to content

Admit missionless completions after terminal missions - #138

Merged
luciusmagn merged 2 commits into
lambda-symbolics:masterfrom
htayj:fix/missionless-completion-after-terminal-mission
Oct 28, 2026
Merged

luciusmagn merged 2 commits into
lambda-symbolics:masterfrom
htayj:fix/missionless-completion-after-terminal-mission

Conversation

@htayj

@htayj htayj commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #137

Problem

After a mission ends, an unrelated job can finish without resuming the primary. Its completion has no mission identity, but admission and dispatch require authority from the retained mission. The user has to type something before the session continues.

Fix

  • application-job-completions--notice-admissible-p admits missionless completions when the retained mission is inactive. Mission-bound notices still require matching active mission authority.
  • application-job-completions-run keeps the admissible notices from the ticket and runs mission admission only when one of them carries a mission identity. Missionless turns do not update the retained mission's continuation counter.
  • Following upstream mission--request-owned-p, a non-active mission does not own new ordinary work. Missionless turns use ordinary inference outside its budgets; an explicit controller queue pause still prevents automatic work.
  • Jobs started during a mission stay mission-bound.

Tests

  • test-job-completion-controller-after-terminal-mission: a real asynchronous job resumes the primary through the indexed service and controller after a verified mission. Stale mission-bound work cannot resume it, the retained mission is unchanged, and replay cannot start a second turn.
  • test-job-completion-terminal-mission-authority: checks mission identity and state combinations, notification-only policy, foreign ownership and controller pause.

Validation

On 0.67.8 (40e8207e), Linux x86-64, SBCL 2.6.6:

  • ./script/check --source passes.
  • job-completion-controller fails 2 of 12 cases without the fix and passes 12/12 with it.
  • Full ./script/check: 1,235 cases, 2 failures. The same 2 fail on unchanged 40e8207e: test-telemetry-subprocess-deadlines (the saved-core child cannot load libcrypto.so.3) and test-model-catalog-standalone-http (bounded-body assertion).

@luciusmagn
luciusmagn force-pushed the fix/missionless-completion-after-terminal-mission branch from 7abe0fe to 3bd3616 Compare October 28, 2026 08:27
@luciusmagn
luciusmagn merged commit bbc7cee into lambda-symbolics:master Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job completions do not resume the primary after a mission ends

2 participants