Repository navigation
Admit missionless completions after terminal missions - #138
Merged
luciusmagn merged 2 commits intoOct 28, 2026
Merged
luciusmagn merged 2 commits into
luciusmagn merged 2 commits into
Conversation
luciusmagn
force-pushed
the
fix/missionless-completion-after-terminal-mission
branch
from
October 28, 2026 08:27
7abe0fe to
3bd3616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
Problem
After a mission ends, an unrelated job can finish without resuming the primary. Its completion has no mission identity, but admission and dispatch require authority from the retained mission. The user has to type something before the session continues.
Fix
application-job-completions--notice-admissible-padmits missionless completions when the retained mission is inactive. Mission-bound notices still require matching active mission authority.application-job-completions-runkeeps the admissible notices from the ticket and runs mission admission only when one of them carries a mission identity. Missionless turns do not update the retained mission's continuation counter.mission--request-owned-p, a non-active mission does not own new ordinary work. Missionless turns use ordinary inference outside its budgets; an explicit controller queue pause still prevents automatic work.Tests
test-job-completion-controller-after-terminal-mission: a real asynchronous job resumes the primary through the indexed service and controller after a verified mission. Stale mission-bound work cannot resume it, the retained mission is unchanged, and replay cannot start a second turn.test-job-completion-terminal-mission-authority: checks mission identity and state combinations, notification-only policy, foreign ownership and controller pause.Validation
On 0.67.8 (
40e8207e), Linux x86-64, SBCL 2.6.6:./script/check --sourcepasses.job-completion-controllerfails 2 of 12 cases without the fix and passes 12/12 with it../script/check: 1,235 cases, 2 failures. The same 2 fail on unchanged40e8207e:test-telemetry-subprocess-deadlines(the saved-core child cannot loadlibcrypto.so.3) andtest-model-catalog-standalone-http(bounded-body assertion).