Repository navigation
Conversation
|
What mac version and gem version this is tested? |
Author
|
macOS 15.6.1 (24G90) on M4 Pro, ruby version 3.4.5, ruby-oci8 version 2.2.14 and main (revert d1daf45) |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The version compatibility check and macOS installation documentation have unresolved issues.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Enables Apple Silicon macOS support by removing obsolete binding-dump support, updating version validation, and revising installation guidance.
Changes:
- Removes binding-dump compilation, initialization, and workflow support.
- Updates native extension version validation.
- Adds ARM64 Oracle Instant Client installation instructions.
| File | Summary |
|---|---|
lib/oci8.rb |
Updates extension version validation; exact version comparison should be retained. |
ext/oci8/oci8lib.c |
Removes binding-dump initialization. |
ext/oci8/oci8.h |
Removes the binding-dump declaration. |
ext/oci8/extconf.rb |
Stops compiling dump_bindings.o. |
ext/oci8/dump_bindings.c |
Removes obsolete binding-dump implementation. |
docs/install-on-osx.md |
Adds ARM64 guidance; Intel support and several setup steps need correction. |
.github/workflows/dump-bindings.yml-disabled |
Removes obsolete workflow configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| require 'oci8/version.rb' | ||
| if OCI8::VERSION != OCI8::LIB_VERSION | ||
| if OCI8::VERSION.split('.').take(3).join('.') != OCI8::LIB_VERSION.split('.').take(3).join('.') |
Comment on lines
+15
to
+19
| Go [oracle site](https://www.oracle.com/database/technologies/instant-client/macos-arm64-downloads.html) and download: | ||
|
|
||
| * instantclient-basiclite-macos.arm64-23.3.0.23.09.dmg | ||
| * instantclient-sdk-macos.arm64-23.3.0.23.09.dmg | ||
| * instantclient-sqlplus-macos.arm64-23.3.0.23.09.dmg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please notice I need revert d1daf45 commit in order to make it works.