Repository navigation
test(conformance): rename seven label-text cases that are now refused - #23
Merged
Merged
Conversation
Since the ruling that refuses any line holding ::: or @{ (#20, #21),
seven boundary cases named label-text-...-accepted expect a refusal.
Rename each to ...-refused, the suffix the other refusing boundary
cases use, so a case's name matches its expectation.
Every reference to the old names, in the README tables and in the
Twin lines and headings of WHY.md files, follows the rename, and the
README's provenance note now says the cases were renamed. No input or
expect.json changes.
Signed-off-by: Cameron Brooks <95648474+CameronBrooks11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #20 and #21, any line holding
:::or@{isnot-admitted. That left seven boundary cases namedlabel-text-…-acceptedthat expect a refusal. This PR renames each to…-refused, the suffix the other refusing boundary cases use:boundary/label-text-at-brace-in-quoted-edge-label-acceptedboundary/label-text-at-brace-in-quoted-edge-label-refusedboundary/label-text-at-brace-in-quoted-node-label-acceptedboundary/label-text-at-brace-in-quoted-node-label-refusedboundary/label-text-at-brace-in-quoted-title-acceptedboundary/label-text-at-brace-in-quoted-title-refusedboundary/label-text-triple-colon-in-quoted-node-label-acceptedboundary/label-text-triple-colon-in-quoted-node-label-refusedboundary/label-text-triple-colon-in-unquoted-edge-label-acceptedboundary/label-text-triple-colon-in-unquoted-edge-label-refusedboundary/label-text-triple-colon-in-unquoted-node-label-acceptedboundary/label-text-triple-colon-in-unquoted-node-label-refusedboundary/label-text-triple-colon-in-unquoted-title-acceptedboundary/label-text-triple-colon-in-unquoted-title-refusedAll renames use
git mv. Every reference to an old name follows: theconformance/cases/README.mdtables, plus the headings and**Twin:**lines inWHY.mdfiles. The README's provenance note said these cases kept their names, so it now says they were renamed. Noinput.mmdorexpect.jsonchanges. The "Changed at 374b8a9 from accepted." lines are true as history and stay.After the rename, every
*-acceptedcase expects{"accept": true}and every*-refusedcase expects a refusal. Onmainthe same scan flags exactly these seven.Independent of #22. The two touch different parts of
conformance/cases/README.md.Gates