Repository navigation
peer mail: reading the inbox no longer rewrites sent history - #1799
Merged
Merged
Conversation
At each step boundary with an empty inbox, placeWaitingBeforeHuman removed
every peer wake line from the whole history, including the one the
current turn started from, which the model had already been sent. That
rewrote history the provider had cached: on Claude Agent it started a
fresh claude process ("restart: earlier history changed") on every
woken turn, and on other providers it broke the cached prefix.
It now removes only wakes after the last non-user message, the ones the
model was never sent. A leftover wake placed before a human prompt is
still dropped once the inbox is clear.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At each step boundary with an empty peer inbox,
placeWaitingBeforeHumanremoved every peer wake line from the whole history (dropAllInjects), including the one the current turn started from, which the model had already been sent. That rewrote history the provider had cached:claudeprocess ("restart: earlier history changed") and replayed the conversation as a text checkpoint.It now removes only wake lines after the last non-user message, the ones the model was never sent (
dropUnsentInjects). A leftover wake placed before a human prompt is still dropped once the inbox is clear; restore still drops all of them.Test: a wake the model already answered stays in history after the inbox is read; the existing #1137 tests pass. In a scripted peer-mail run on Claude Agent (three addressed follow-ups), restarts went from 3 per run to 0, with every follow-up still done.