Repository navigation
Conversation
review-checkpoint-preserves-unfinished-scope repeated one identical read_file twenty times to stand in for a long review; the identical-call guard (#1706) now ends such a turn at eight. Reading a different seeded note per call keeps the review long without looping, as the sibling review-mode and ACP checkpoint tests already do. The case passes with and without the guard. Co-Authored-By: Codegraff <blackfloofie@codegraff.com>
Owner
Author
|
Merged into main through #1800 (v0.302.69); this PR targeted an old release branch, so it is closed by hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tier-2 case review-checkpoint-preserves-unfinished-scope stood in for a long review by repeating one identical read_file twenty times. The identical-call guard (#1706) now ends that turn at the eighth repeat, so the case failed on the release branch.
The case now reads a different seeded note on each call, the same approach the sibling review-mode and ACP checkpoint cases use. The review stays long without looping, and the case passes with and without the guard. The full tier-2 suite shows no new failures.
Co-Authored-By: Codegraff blackfloofie@codegraff.com