Repository navigation
Conversation
…ults Enable the verified bounded mmap dictionary on current main, preserving the integrated watcher CPU fixes and retrieval breadth. Signed release publication remains gated by the existing multi-platform workflow.
|
👋 Thanks for the contribution! Quick heads-up: this repo lands changes on the current Please retarget this PR via Edit → base branch to the active (Automated hint — reply here if you need a hand.) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Problem
During a parallel cold scan, all worker arenas remain allocated until every word-index shard has been merged. At the end of the merge, the completed destination index and all source shards coexist in memory.
Release each worker arena immediately after its shard has been copied into the destination index. The existing cleanup path still handles the current and remaining workers when a merge fails. This reduces the merge-phase peak; it does not impose an overall indexing memory limit or establish that it resolves every large-repository OOM.
Evidence
codedbprocess after reporting 29,776,092 KiB of anonymous resident memory (approximately 28.4 GiB / 30.5 GB). This is an observed OOM, not evidence that this change alone prevents that incident.0.17.0-dev.813+2153f8143, Linux x86_64,ReleaseFast, eight scan workers./usr/bin/time; processes capped at 1 GiB address space).expected 0, found 1586bytes retained) and passes after the change. A second regression covers merge failure and caller cleanup.zig build test-index -Dtest-filter='watcher: parallel word-index shards match sequential'passes.zig fmt --check src/watcher.zigandgit diff --checkpass.Verification limitations
zig build test -j1fails in this environment on two watcher notification tests, repeated across test binaries. The same two tests fail in an unmodified checkout of the base commit.AnnDirectorySyncFailedon both the base and modified binaries in this environment.