Repository navigation
Phase 10: public security and bug fixes - #632
Merged
Merged
Conversation
…in FormData uploads
Clicks on other elements with a submit type, or on submit controls outside a form, are ignored.
…Value and selected (#600)
abort() rejects the Deferred and fires ajaxComplete and ajaxStop; an emulated 2xx status no longer turns a parser error into success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 10 of
docs/plans/modernization.md: the public part of the security and bug fixes.Review findings (
docs/research/security-review.md)elements,setAttribute,removeAttribute,action) no longer breakformToArrayor the iframe transport. Theclkexpandos stay on the form until 5.x.hasOwnPropertyis called through the prototype. This clears the threeno-prototype-builtinswarnings, and the rule is now an error.urls keep the form data.data: {}no longer adds an empty FormData field, and FormData uploads honor the globaltraditionalsetting.Issues
<button>without atypeattribute is captured as the submitter.resetForm,clearFields,fieldValueandselectedaccept nodes without a tag name.consistent-thisrule #553:dist/no longer ships/* eslint */or/* global */comments.Iframe transport (
docs/research/coverage-findings.md)ajaxCompleteandajaxStop.Verification
it.failsrecords are nowit, and every fix has new tests.main.docs/research/4x-behavior-changes.md, and the Phase 10 column is indocs/metrics.md. The CI and CodeQL cells are filled in after this PR's run.The label lookup record and #597 land with the remaining Phase 10 items on release day.
🤖 Generated with Claude Code