Repository navigation
fix: address PR #10 review feedback - #11
Merged
Merged
Conversation
- Build the source PDF link from the site base so it works on exporter sub-routes; serve /<year>/*.pdf in standalone `make dev` - site.mjs: return 400 for malformed URLs, guard Referer parsing, check ports up front, log dead deck servers, drain request on upstream error - make preview builds into dist-preview/ instead of overwriting dist/ - Sanitize class labels, skip hidden slides in section numbering - Share SHOWCASE constant, escape showcase link, add site-request tests - Add .prettierrc.json, document !important and staircase fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review feedback on #10.
Changes
make devalso serves/<year>/*.pdf. The decks'sourcePdfis now a site-root-relative path.make siterobustnesssite-request.mjs+ tests)make preview: The showcase build goes todist-preview/, sodist/is no longer overwritten.\and newlines.SHOWCASEconstant is shared and the showcase link is escaped..prettierrc.json.!importantrules and the staircase default.Not included
cover-bg.png: it differs fromtooling/site/images/cover-bg.pngand is still used, so it stays.Verification
pnpm checkpasses (17 tests, README sync, full build)make site:/%returns 400 and the list still returns 200; the PDF is served asapplication/pdfapplication/pdf