Skip to content

fix: address PR #10 review feedback - #11

Merged
jmnote merged 1 commit into
mainfrom
fix/review-feedback-pr10
Nov 2, 2026
Merged

jmnote merged 1 commit into
mainfrom
fix/review-feedback-pr10

Conversation

@jmnote

@jmnote jmnote commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

Addresses the review feedback on #10.

Changes

  • PDF download link: The URL is now built from the site base, so it works on exporter sub-routes. Standalone make dev also serves /<year>/*.pdf. The decks' sourcePdf is now a site-root-relative path.
  • make site robustness
    • Malformed percent-encoded URLs and Referer headers no longer crash the server; they get a 400 or a fallback. (site-request.mjs + tests)
    • Ports are checked up front, and dead or failed deck servers are logged.
    • The request body is drained on upstream errors.
  • make preview: The showcase build goes to dist-preview/, so dist/ is no longer overwritten.
  • Misc
    • Class labels strip \ and newlines.
    • Hidden slides are skipped in section numbering.
    • The SHOWCASE constant is shared and the showcase link is escaped.
    • Added .prettierrc.json.
    • Commented the !important rules and the staircase default.
    • README now notes the per-deck dev server.

Not included

Verification

  • pnpm check passes (17 tests, README sync, full build)
  • make site: /% returns 400 and the list still returns 200; the PDF is served as application/pdf
  • Standalone dev server: the PDF is served as application/pdf

- Build the source PDF link from the site base so it works on exporter
  sub-routes; serve /<year>/*.pdf in standalone `make dev`
- site.mjs: return 400 for malformed URLs, guard Referer parsing, check
  ports up front, log dead deck servers, drain request on upstream error
- make preview builds into dist-preview/ instead of overwriting dist/
- Sanitize class labels, skip hidden slides in section numbering
- Share SHOWCASE constant, escape showcase link, add site-request tests
- Add .prettierrc.json, document !important and staircase fallbacks
@jmnote
jmnote merged commit 2b01373 into main Nov 2, 2026
2 checks passed
@jmnote
jmnote deleted the fix/review-feedback-pr10 branch November 2, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant