Refuse unsafe MCP payloads and attach local_review notes - #10
Merged
Conversation
The stdio server now drops .env files, private-key/token blobs, oversized file sets, and huge max_tokens before Ollama is called. Security-sensitive orchestrated jobs call local_review first and attach those notes to the premium packet. CI also runs the stub observed failover profile. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No-GPU follow-on after the review handoff. Two gaps that still showed up without a workstation GPU:
Server-side refuse
Eval routing already kept
.envofflocal_*. The MCP server did not._run_toolnow inspects the payload before Ollama:.env,id_rsa,credentials.json)max_tokensabove 8192A snippet that only mentions
passwordis still allowed (login()review cases).local_reviewpreludeSecurity-sensitive orchestrated jobs call
local_reviewfirst and attach those notes to the premium packet. That still cannot approve.CI also runs the stub observed failover profile.
103 unit tests passed on this agent. Still no live GPU rates and this Cloud Agent still cannot call
local_*as its own tools.