Fail closed when Grok STT coerces bool start to 1.0 - #146
Merged
Conversation
Grok STT used float(start or 0.0), so true became 1.0 and a missing start dumped the board at t=0. Require JSON numbers before writing timing.json. Co-authored-by: jmjava <jmjava@gmail.com>
ruff green; pytest 812 passed, 1 skipped; docgen benchmark meets baseline. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
load_bundle_timingalready requires JSON-numberstart/end(#134). Grok STT ingest still didfloat(w.get("start") or 0.0).start: truebecame 1.0. Missing / nullstartbecame 0.0 and dumps the board.duration: truebecame 1.0. That payload is whattimestamps --engine whisperwrites intotiming.jsonwhenai.provideris grok.Change
_stt_json_numberrequires int/float (not bool) for word/segmentstart/endand presentdurationdurationstill falls back to last word endstart: 0.0stays 0Gate
ruff check src/ tests/greenpytest tests/— 812 passed, 1 skippeddocgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(no clock change; no--update-baseline)Out of scope
.start/.end)end >= startMilestone:
milestones/grok-stt-start-end.md