Fail closed when validate stream probes ignore ffprobe exit - #145
Merged
Conversation
stream_presence and av_drift parsed leftover ffprobe JSON without checking returncode, so a corrupt recording that still printed streams could pass pre-push hard checks. Co-authored-by: jmjava <jmjava@gmail.com>
ruff green; pytest 808 passed, 1 skipped; docgen benchmark meets baseline. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 8, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #135 made duration probes ignore ffprobe stdout on nonzero exit. Pages followed in #143. Validate
_check_streams/_check_driftstilljson.loads(out.stdout)with noreturncodecheck.Empty stdout already fails
json.loads(failed check). Leftover JSON that lists video+audio streams can passstream_presence/av_drifton a corrupt recording. Those checks are hard invalidate --pre-push.Change
Validator._ffprobe_json: nonzero exit, timeout, missing binary, or unparsable JSON raises; callers turn that into a failed checkreturncode != 0Gate
ruff check src/ tests/greenpytest tests/— 808 passed, 1 skippeddocgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(no clock change; no--update-baseline)Out of scope
start/endfloat(... or 0.0)inai_clientMilestone:
milestones/validate-stream-probe.md