Repository navigation
Conversation
…plates (Spring Boot & Multi-module) Context - The security patch in 4.5.5 (for GHSA-pvrx-3g7m-fpgv) introduced strict OS-level canonical file checks for all template prefixes. Bug - This breaks legitimate template resolution for classpath: resources in packaged Spring Boot applications (Fat JARs) and multi-module project environments. resolveBaseDirectory() attempts to map virtual or multi-root classpath locations to a single absolute OS directory, causing the startsWith() containment check to fail and throw false-positive IllegalArgumentException path traversal errors.
Owner
Author
|
@glitke-dev can you check? |
|
Verified the PR head (81ac705) against all cases from #1199: directory and JAR, two classpath roots with the template in the second, JAR + directory mixed, and a real Spring Boot fat JAR ( Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…plates (Spring Boot & Multi-module)
Context
Bug