Add username to atc output - #3690
Open
CharlieAtSchneider wants to merge 4 commits into
Open
Conversation
CharlieAtSchneider
had a problem deploying
to
build-gate
September 1, 2026 08:28 — with
GitHub Actions
Error
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
CharlieAtSchneider
had a problem deploying
to
build-gate
September 1, 2026 11:00 — with
GitHub Actions
Error
CharlieAtSchneider
requested a deployment
to
build-gate
September 2, 2026 08:06 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds username to
jf atcoutput. Since it isn't appearing in the reply to the API call, it is instead manually appended to the output in code.Please tell me if you think the idea is sound. If so, I can fix my issue in the Caveats section below.
Examples:
jf atc:jf atc --format=tableUse case
If you can't run
jf dockercommands, (in our case due to VM shenanigans) you may need to have a username together with the token to log in to Docker. This addition tojf atcwould fix this.Caveats:
json.Unmarshal(), add a username field to the struct, turn it back withjson.Marshal()for it to just turn back withjson.Unmarshal()later in the code in other functions that I didn't touch. What do you think - should this be avoided with the help of some refactoring?Tests, formatting etc
masterbranch.go vet ./....go fmt ./....All code written by a human