Skip to content

feat: add JFROG_CLI_CERTS_DIR env support - #1607

Open
andreasvikke wants to merge 6 commits into
jfrog:masterfrom
andreasvikke:master
Open

feat: add JFROG_CLI_CERTS_DIR env support#1607
andreasvikke wants to merge 6 commits into
jfrog:masterfrom
andreasvikke:master

Conversation

@andreasvikke

Copy link
Copy Markdown
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the master branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR introduces the env variable JFROG_CLI_CERTS_DIR for overriding the certificates directory.
More information about the feature can be found here jfrog/jfrog-cli#3661

@github-actions

Copy link
Copy Markdown
Contributor

@fluxxBot fluxxBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please raise a PR on jfrog-cli - https://github.com/jfrog/jfrog-cli with a integration test

Comment thread utils/coreutils/utils.go Outdated
Comment thread utils/coreutils/utils_test.go Outdated
Comment thread utils/coreutils/utils.go
@fluxxBot

Copy link
Copy Markdown
Contributor

also tests are failing please take a look

Co-authored-by: Kanishk Gupta <kanishkg@jfrog.com>
@andreasvikke

Copy link
Copy Markdown
Author

@fluxxBot

I have implemented some changes based on your review, and i should have fixed the test failing on Windows.
Please also see the integration test implementation at jfrog/jfrog-cli#3683

@fluxxBot

fluxxBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@andreasvikke please check this replace directive here - https://github.com/jfrog/jfrog-cli/pull/3683/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R253
please replace it with the commit associated with this PR

@andreasvikke

andreasvikke commented Sep 2, 2026

Copy link
Copy Markdown
Author

@andreasvikke please check this replace directive here - https://github.com/jfrog/jfrog-cli/pull/3683/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R253 please replace it with the commit associated with this PR

Ofc. i have now made the replace, so it point at the head commit of this PR.
Im not able to point it to github.com/jfrog/jfrog-cli-core... as the commit is non existing until merge.
Therefore i pointed it at my Fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants