Allow the ability to specify a custom temp directory - #74
Closed
eric-vlaanderen wants to merge 3 commits into
Closed
Allow the ability to specify a custom temp directory #74eric-vlaanderen wants to merge 3 commits into
eric-vlaanderen wants to merge 3 commits into
Conversation
…it is used by RCodeUtils for new data frames.
…the same tempfileservice - i.e. setRCode has been called with a new rcode object
Owner
|
Please keep the backwards compatibility. |
Contributor
Author
|
This change does not break backwards compatibility. But if RCaller and RCode are created separately, they may not share a temp directory if a custom tempDir is specified in the RCode but RCaller.create() is used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a custom temp directory to be specified when creating the RCode object and ensures that the specified directory is used when creating a new dataframe.
Unfortunately the custom temporary directory will not be respected if RCaller and Rcode are created separately and then RCaller.setCode(rCode) is called (such as in the RService class and the example java classes).
Suggest that the RService and example usage java classes are updated to create a single RCode object (at the moment one is created with the static RCode.create() method and another is created inside the RCaller.create() method) and the RCaller.setRcode(...) method is removed - although this would likely break backwards compatibility.
the code
could be replaced by either:
or
depending on the author's preference.