Skip to content

Upgrade gradle configuration to support java 17+ - #73

Merged
jbytecode merged 3 commits into
jbytecode:masterfrom
eric-vlaanderen:java_upgrade
Aug 28, 2026
Merged

Upgrade gradle configuration to support java 17+#73
jbytecode merged 3 commits into
jbytecode:masterfrom
eric-vlaanderen:java_upgrade

Conversation

@eric-vlaanderen

Copy link
Copy Markdown
Contributor

Update gradle version to support newer versions of java, minor typos in ROutputParser which caused errors in newer java versions. Add jvm options to the gradle test target to prevent test failures on java 17+. Update to latest versions of arrow and commons-lang3.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The build configuration introduces open-ended Arrow version ranges and contains a misleading JVM-arg comment, both of which increase the risk of unexpected future build/test breakage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the project’s Gradle setup and dependencies to improve compatibility with newer Java versions (17+), and fixes Javadoc tag typos that can trigger stricter doclint errors on newer JDKs.

Changes:

  • Upgraded the Gradle wrapper distribution to a newer Gradle 8.x release.
  • Updated Arrow and commons-lang3 dependency versions, and added Arrow unsafe memory dependency for tests.
  • Added JVM args to the Gradle test task to reduce Java 17+ reflective/module-access related test failures; corrected @throw@throws in ROutputParser Javadocs.
File summaries
File Description
RCaller/src/main/java/com/github/rcaller/rstuff/ROutputParser.java Fixes invalid Javadoc tag usage (@throw@throws) related to Arrow/XML parser API docs.
RCaller/gradle/wrapper/gradle-wrapper.properties Updates Gradle wrapper distribution URL to a newer Gradle version.
RCaller/build.gradle Bumps dependency versions and adds Java 17+ oriented JVM args for tests; adjusts Arrow-related test dependencies.
Review details

Suppressed comments (1)

RCaller/build.gradle:25

  • Same concern for test dependencies: the open-ended Arrow ranges ([19.0.0,)) can introduce unplanned major upgrades and CI breakage. Bounding to <20.0.0 keeps you on Arrow 19.x while still allowing minor/patch updates.
    testImplementation 'org.apache.arrow:arrow-vector:[19.0.0,)'
    testImplementation 'org.apache.arrow:arrow-memory-netty:[19.0.0,)'
    testImplementation 'org.apache.arrow:arrow-memory-unsafe:[19.0.0,)'
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread RCaller/build.gradle Outdated
Comment thread RCaller/build.gradle
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@jbytecode jbytecode left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow vector version [19.0.0) to [19.0.0,20.0.0)

@jbytecode
jbytecode merged commit 70222bc into jbytecode:master Aug 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants