Repository navigation
Ship the MIT LICENSE in every publishable package - #253
Merged
Merged
Conversation
Copy the root MIT LICENSE into each npm package and sync it before pack so adapter tarballs cannot omit the license file. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 13 +1
Lines 1664 1723 +59
Branches 289 304 +15
=========================================
+ Hits 1664 1723 +59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix. Every publishable package now ships the MIT LICENSE in its npm tarball.
Summary
@qified/redis,@qified/rabbitmq,@qified/valkey,@qified/nats, and@qified/zeromqlistedLICENSEinfilesbut had no LICENSE file in the package directory. Only the repo root andpackages/qifiedhad one, so the next publish from main would omit the license from those adapters.qifiedalready had the file and is unchanged.LICENSEin each adapter package.scripts/license-sync.tsandpnpm license:sync, modeled on keyv. It readspnpm-workspace.yamland copies the root LICENSE into every non-private workspace package.pnpm pack:packagesruns that sync before packing. The release workflow fails the pack step if any tarball is missingLICENSE.pnpm testandpnpm test:cirunpnpm test:scripts, which covers the sync script at 100% and packs each package to assertpackage/LICENSEis present.No version bump. Nothing is published to npm.