Skip to content

fix: security - refresh patched transitive dependencies - #252

Merged
jaredwray merged 1 commit into
mainfrom
cursor/security-lockfile-refresh-5e62
Oct 26, 2026
Merged

jaredwray merged 1 commit into
mainfrom
cursor/security-lockfile-refresh-5e62

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing and Code of Conduct guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

No application code changed. The existing suite still passes with 100% statement and line coverage.

What kind of change does this PR introduce?

Security fix. Lockfile refresh (plus a root vite devDependency) so vulnerable transitive packages resolve to patched releases. Supply-chain flags (@pnpm/network.ca-file, cmake-ts, json-schema) are unchanged. No overrides and no minimumReleaseAgeExclude entries.

Parent ranges already allowed these releases, except vite: vitest peers vite@^6.4.0 || ^7.0.0 || ^8.0.0, and pnpm update does not float that auto-installed peer. Declaring vite@^8.3.4 at the repo root selects 8.3.4, which requires postcss@^8.5.29 and pulls the postcss, nanoid, and source-map-js fixes with it.

minimumReleaseAge (7 days) skipped vite 8.3.5 (published 2026-10-21). The lockfile resolved vite 8.3.4, which is >=8.3.3 and clear of current advisories.

Package Old New Advisory
brace-expansion 1.1.15 1.1.21 DoS. GHSA-3jxr-9vmj-r5cp (fixed 1.1.16), GHSA-mh99-v99m-4gvg (fixed 1.1.17), GHSA-rgw5-rvv9-x895 (fixed 1.1.18), GHSA-6j4f-fj2g-mc7p (fixed 1.1.19), GHSA-qhr7-859c-m2p7 (fixed 1.1.20), GHSA-q2hr-2g5m-vwhr (fixed 1.1.21). 1.1.21 is the latest 1.x.
brace-expansion 5.0.6 5.0.12 Same DoS advisories on the 5.x line, fixed in 5.0.7 through 5.0.12. 5.0.12 is the latest 5.x.
nanoid 3.3.12 3.3.20 GHSA-28wg-ghj8-5hjv (fixed 3.3.16), GHSA-2v37-7h3g-55p8 (fixed 3.3.18). postcss 8.5.31 depends on nanoid@^3.3.20.
postcss 8.5.15 8.5.31 GHSA-r28c-9q8g-f849 (fixed 8.5.18), GHSA-fxqj-rqcc-2cmp (fixed 8.5.23). 8.5.18 is still affected by the second advisory. 8.5.31 is the newest 8.5 release outside the 7-day window.
undici 7.27.2 and 7.29.1 7.30.1 7.29.1 is still affected by GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472, and GHSA-xjj6-f33q-929c, all fixed in 7.30.1. 7.27.2 also carried the earlier undici advisories fixed on the way to 7.30.1.
undici 8.10.2 8.12.3 Same three advisories, fixed in 8.12.2. 8.12.3 is the current latest and is outside the release-age window.
vite 8.0.11 8.3.4 GHSA-fx2h-pf6j-xcff and GHSA-v6wh-96g9-6wx3 (fixed 8.0.16). On the 8.3 line, GHSA-9jrq-w75r-8gcw, GHSA-rq7h-c2jc-7f22, GHSA-vfpm-58rq-9qcg, GHSA-587h-7wmj-h5pm, GHSA-698v-4r3x-3vcv, and GHSA-r825-w8mm-5pxw are fixed in 8.3.3. Resolved 8.3.4 because 8.3.5 is inside minimumReleaseAge.
source-map-js 1.2.1 1.2.2 GHSA-68fv-2mgg-jv7q (fixed 1.2.2).
zod 4.4.3 4.6.7 GHSA-mrhx-c7xc-m3w5 (fixed 4.6.6). 4.6.7 is the latest and is outside the release-age window.
markdown-it 15.0.1 15.0.3 GHSA-r7fv-28h4-cvq7 (fixed 15.0.2), GHSA-gfr2-rv44-r23c and GHSA-vfgh-jcmw-g37q (fixed 15.0.3). @jaredwray/fumanchu@4.7.3 already depends on markdown-it@^15.0.0, so 15.0.3 resolves without a fumanchu release.

Verification

pnpm install --frozen-lockfile, pnpm build, and pnpm test:ci on Node 22.23.3. Redis, Valkey, NATS, and RabbitMQ were up. Lint and tests passed in every workspace package; statement and line coverage stayed at 100%.

Open in Web Open in Cursor 

Move brace-expansion, nanoid, postcss, undici, vite, source-map-js, zod, and markdown-it onto patched releases. Declare vite as a root devDependency so the vitest peer resolves to 8.3.4.

Co-authored-by: Jared Wray <me@jaredwray.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-26T14:23:12.282462Z 47466da PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvite@​8.0.11 ⏵ 8.3.499 +1100 +2882 +198 +2100

View full report

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (215bab3) to head (47466da).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         1664      1664           
  Branches       290       290           
=========================================
  Hits          1664      1664           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit 68910f2 into main Oct 26, 2026
13 checks passed
@jaredwray
jaredwray deleted the cursor/security-lockfile-refresh-5e62 branch October 26, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants