Repository navigation
Initial commit: itential.valkey collection - #2
Merged
Amunagala-itential merged 5 commits intoSep 29, 2026
Merged
Conversation
Standalone Ansible collection installing Valkey as a Remi-free, EL9/Amazon Linux 2023-only alternative to itential.deployer's redis role. Depends on itential.deployer at runtime for the shared common and offline utility roles. This collection is transitional: it exists separately from itential.deployer only until roles/redis is retired there, at which point roles/valkey and its playbooks are intended to be merged directly into itential.deployer.
8 tasks done
Amunagala-itential
requested review from
Madias2222,
Nick-Andreano and
kvelarde-itential
September 17, 2026 10:53
Replaces the "Quick Start" stub (which just linked out to itential.deployer's own README) with an actual step-by-step flow: installing both collections, setting up the working directory, building a combined inventory (Valkey + MongoDB + Platform), and the verify/install/certify command sequence across both collections. Also documents a real gap found while writing this: itential.deployer's os.yml doesn't yet target valkey_master/valkey_replica/valkey_sentinel, so baseline OS/firewalld setup doesn't run against fresh Valkey hosts via the normal flow. Tracked as a known limitation for now, not fixed here since it lives in a different repo.
- Remove updateChangelog.yml -- redundant with the changelog step already inside publish_ansible_collection.yml (same trigger, same action) - Remove dead valkey_offline_*_archives_dir vars -- leftover from roles/redis's source-tarball download path, which roles/valkey never has (grepped: zero references in roles/valkey/tasks/) - Add Amazon Linux 2023 to the example inventory's platform-support comment, which still said EL9-only from before that support was added - Fix README's incorrect claim that itential.deployer isn't installed automatically -- ansible-galaxy does resolve and install galaxy.yml dependencies by default - Trim README's Getting Started section back to Valkey-only scope, linking to itential.deployer's own README for the rest of the stack instead of re-explaining it inline - Drop the redundant _valkey suffix from playbook names now that this is a standalone single-component collection: verify_valkey.yml -> verify.yml, certify_valkey.yml -> certify.yml, download_packages_valkey.yml -> download_packages.yml (valkey.yml itself is unchanged -- it's named after the component, not a suffixed verb)
Collaborator
Author
|
Addressed in 061a47e:
|
Same class of issue as both prior review rounds: docs copied from roles/redis's redis_guide.md weren't fully adapted to this collection. - "this deployer"/"the deployer" -> "this role" where the text is actually describing roles/valkey itself, not itential.deployer - Two references to `redis_guide.md` (a file that only exists in itential.deployer, not in this repo) now link to its real location on GitHub instead of a dangling local filename - The example inventory's TLS comment pointed at a nonexistent tls_guide.md; TLS is actually documented inline in this collection's own docs/valkey_guide.md, so it now points there instead Found via a proactive /code-review pass looking specifically for more instances of the dead-copy-paste-reference pattern the reviewer had already caught twice.
Nick-Andreano
approved these changes
Sep 21, 2026
Nick-Andreano
left a comment
Nick-Andreano
left a comment
There was a problem hiding this comment.
One thing I notices is that some of the documents have
Copyright (c) 2024
Probably should be 2026
Contributor
@Amunagala-itential I agree with Nick. Let's change these copyright lines and then I think this PR is ready to merge. |
Per Nick's review comment (via kvelarde-itential): several files still carried "Copyright (c) 2024" copied forward from roles/redis, even though every file in this collection was actually authored in 2026. Fixed all 22 instances for consistency with the 6 files that already correctly said 2026.
Collaborator
Author
|
Copyright year fixed across all 22 affected files, matching the 6 that already said 2026. |
kvelarde-itential
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initial scaffold of the standalone
itential.valkeyAnsible collection: installs Valkey as a Remi-free, EL9/Amazon Linux 2023-only alternative toitential.deployer'sredisrole.This collection is transitional — it exists separately from
itential.deployeronly untilroles/redisis retired there, at which pointroles/valkeyand its playbooks are intended to be merged directly intoitential.deployer.Depends on
itential.deployerat runtime for the sharedcommon/offlineutility roles (referenced by FQCN).Contents
roles/valkey/— the role, ported fromitential.deployer's in-progress PR (#374 there), withcommon/offlinecalls rewritten to FQCN and internal variables renamed with avalkey_prefix for namespace safetyplaybooks/valkey.yml,verify_valkey.yml,certify_valkey.yml,download_packages_valkey.ymldocs/valkey_guide.md,example_inventories/valkey/itential.deployer's conventions (ansible-lint,role-readme-check, changelog/publish workflows)Test plan
ansible-lintclean (0 failures) with bothitential.valkeyanditential.deployerregistered as collectionscertify_valkey.ymlpasses clean on all hosts, cross-collection FQCN resolution confirmed working end-to-end