Repository navigation
Added meta dir for galaxy publish - #5
Conversation
…ed filesystem paths
… fixes (itential#4) * HTTPS by default/removed test inventory files/ lint fixes (itential#3) * Updated HTTPS to be default, removed testing inventory file and updated filesystem paths * Lint fixes
| @@ -0,0 +1,14 @@ | |||
| galaxy_info: | |||
There was a problem hiding this comment.
I think we need to investigate this lint error.
There was a problem hiding this comment.
This is different from itential.deployer. Deployer has a runtime.yml file. @Nick-Andreano did this file get generated automatically? Or did you create it?
There was a problem hiding this comment.
From what I read, the meta/runtime is collection level. the mcp/meta/main.yaml is role level. The deployer comes as a combo of redis, mongo, iap, etc roles. Those roles were not ment to be publish independently. The MCP is a single purpose collection wrapping a single role. It makes the single role self-describing in a way that the deployers roles dont need to be. In theory, we could publish the standalone mcp role with this role level file. Even though we are publishing it as its own collection, its still a valid place to put the meta variables.
There was a problem hiding this comment.
I'm second guessing this. I dont think we will ever need to publish the role without the collection and I would rather remain consistent across all of our collection. @kvelarde-itential do you agree?
There was a problem hiding this comment.
A role and a collection are different things. A role doesn't have playbooks and so the end user is expected to integrate the role into their own playbooks. We use collections so that things are ready to use. So I believe we should create a collection here.
|
@steven-schattenberg-itential The lint error is strange Those map to old AMI versions and Amazon Linux 2, not Amazon Linux 2023. There's no lint-valid string for AL2023 specifically. I think we can go with "all" and make sure we say its been validated with 2023 in the documentation. |
* Updated HTTPS to be default, removed testing inventory file and updated filesystem paths (#1) * HTTPS by default/removed test inventory files/ lint fixes (#3) * Updated HTTPS to be default, removed testing inventory file and updated filesystem paths * Lint fixes * Added meta dir for galaxy publish (#5) * Updated HTTPS to be default, removed testing inventory file and updated filesystem paths * Lint fixes * Updated HTTPS to be default, removed testing inventory file, and lint fixes (#4) * HTTPS by default/removed test inventory files/ lint fixes (#3) * Updated HTTPS to be default, removed testing inventory file and updated filesystem paths * Lint fixes * Update galaxy version and changelog for release 0.1.0 [skip ci] * added meta dir for galaxy publish * removed meta for role * updated Claude file --------- Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: github-actions <github-actions@github.com>
Added meta dir for galaxy publish