Deploys U&E on prod proxmox - #443
Sahil-STFC wants to merge 4 commits into
Conversation
| - static-secret.yaml | ||
| - config.yaml | ||
| - HTTPRoute.yaml | ||
| - backend-traffic-policy.yaml |
There was a problem hiding this comment.
prod-v4 does not use backend-traffic-policy.yaml
ACLay
left a comment
ACLay
left a comment
There was a problem hiding this comment.
Dev proxmox is also failing to sync with a similar error, should we be fixing those files too?
What is the config in the backend traffic policy meant to accomplish? It looks like it's to avoid timeouts, so do we need an equivalent config file to it for use on the proxmox clusters where we use a cilium gateway instead of envoy?
I think it'd be better to name the overlays prod-cilium and prod-envoy, rather than naming them after the clusters. It doesn't feel right to refer to a different cluster's name in the path for the fallback cluster.
| - name: prod-v4 | ||
| - path: prod-v4 | ||
| # Uncomment if you want to deploy to prod-fallback | ||
| - name: prod-fallback | ||
| - path: prod-v4 | ||
| - name: prod-proxmox | ||
| - path: prod-proxmox |
There was a problem hiding this comment.
Each dash starts a new object in the generators list. I think it should look something like this:
| - name: prod-v4 | |
| - path: prod-v4 | |
| # Uncomment if you want to deploy to prod-fallback | |
| - name: prod-fallback | |
| - path: prod-v4 | |
| - name: prod-proxmox | |
| - path: prod-proxmox | |
| - name: prod-v4 | |
| path: prod-v4 | |
| - name: prod-fallback | |
| path: prod-v4 | |
| - name: prod-proxmox | |
| path: prod-proxmox |
| bases: | ||
| - ../../base | ||
| - ../../prod | ||
|
|
||
| namespace: apps | ||
|
|
||
| resources: | ||
| - static-secret.yaml | ||
| - config.yaml | ||
| - HTTPRoute.yaml | ||
|
|
||
| patches: | ||
| - path: patch-image.yaml No newline at end of file |
There was a problem hiding this comment.
None of these referenced files exist in this directory. The versions in the prod overlay will be included by having it as the base, which I think is referenced by the wrong path.
| bases: | |
| - ../../base | |
| - ../../prod | |
| namespace: apps | |
| resources: | |
| - static-secret.yaml | |
| - config.yaml | |
| - HTTPRoute.yaml | |
| patches: | |
| - path: patch-image.yaml | |
| bases: | |
| - ../prod | |
| namespace: apps |
| bases: | ||
| - ../../base | ||
| - ../../prod | ||
|
|
||
| namespace: apps | ||
|
|
||
| resources: | ||
| - static-secret.yaml | ||
| - config.yaml | ||
| - HTTPRoute.yaml | ||
| - backend-traffic-policy.yaml | ||
|
|
||
| patches: | ||
| - path: patch-image.yaml No newline at end of file |
There was a problem hiding this comment.
Similarly in this overlay, many of these files don't exist here.
| bases: | |
| - ../../base | |
| - ../../prod | |
| namespace: apps | |
| resources: | |
| - static-secret.yaml | |
| - config.yaml | |
| - HTTPRoute.yaml | |
| - backend-traffic-policy.yaml | |
| patches: | |
| - path: patch-image.yaml | |
| bases: | |
| - ../prod | |
| namespace: apps | |
| resources: | |
| - backend-traffic-policy.yaml | |
3 participants
closes : #440