feat(test/gnmi): Enable cisco-nxos-gnmi - #522
Open
nikatza wants to merge 3 commits into
Open
Conversation
nikatza
force-pushed
the
add-gnmi-tests-nxos
branch
6 times, most recently
from
August 25, 2026 15:12
20712ac to
e6faa9f
Compare
nikatza
marked this pull request as ready for review
August 25, 2026 15:19
hardikdr
added
the
area/switch-automation
Contributor
|
Please note that this project doesn't follow semantic commits: https://github.com/ironcore-dev/network-operator/blob/main/AGENTS.md?plain=1#L53-L57 |
nikatza
force-pushed
the
add-gnmi-tests-nxos
branch
from
August 26, 2026 08:09
e6faa9f to
daeedba
Compare
Register the NX-OS provider and its controllers (System, VPCDomain, BorderGateway) so integration tests can run against cisco-nxos-gnmi. The Makefile test-gnmi target is switched to use the ginkgo CLI with parallel procs instead of go test. The mock gNMI server is fixed to store list-key values as integers when they are numeric (e.g. VPC domain ID, VNI) so they match the JSON the provider expects in Get responses. Moved the per-test reset from AfterEach into the test body so that each test explicitly owns its initial state setup. A WaitForCacheSync call is added to BeforeSuite to avoid races where tests create resources before informers are ready. Signed-off-by: Pujol <enric.pujol@sap.com>
Signed-off-by: Pujol <enric.pujol@sap.com>
The state/delete assertions intentionally retain some configuration. On NX-OS, deleting a resource does not always clear all device state: - Physical interfaces cannot be removed; they reset to platform defaults (Layer2 access, vlan-1, mtu 1500, trunkVlans 1-4094). - Feature enablement flags (fm-items) stay on after the resource using them is gone. - Config items implementing Defaultable reset to their default value instead of being deleted (e.g. banner, gRPC, jumbo MTU 9216). - SNMP traps cannot be removed once configured on NX-OS, so traps-items persists (as an empty container) after deletion. The ethernetsegment controller gets the resource status via nxapi. This test suite does not support it yet but is left here for reference. Signed-off-by: Pujol <enric.pujol@sap.com>
nikatza
force-pushed
the
add-gnmi-tests-nxos
branch
from
August 26, 2026 08:10
daeedba to
376c01a
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
felix-kaestner
approved these changes
Aug 26, 2026
| @@ -0,0 +1,160 @@ | |||
| # NX-OS AAA TACACS+ with provider config (loginErrorEnable, keyEncryption) | |||
Contributor
There was a problem hiding this comment.
nit: do we need that line? Also I guess "NX-OS" is already clear from the package? (Same applies to all test files).
Contributor
There was a problem hiding this comment.
Shouldn't this just be called bgp_peer.go?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in commit messages. This PR enables preliminaty set of gnmi tests for cisco nxos.