Repository navigation
docs: regenerate architecture.svg at --limit 100 - #44
Merged
Merged
Conversation
test/run.js (60 callees) and render/callgraph.js (57) were cut by the default --limit 50, so the diagram's one edge weighed 29 instead of 55. Regenerate at --limit 100, and pass the same flag in CI's --check step and TECHNICAL.md's regenerate command so they stay the same command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning added in #42 flagged this repo's own diagram: at the default
--limit 50,test/run.js(60 callees) andrender/callgraph.js(57) were cut off.docs/architecture.svgregenerated at--limit 100: thetest/run.js → render/callgraph.jsedge goes from 29 to 55.--checkstep and TECHNICAL.md's regenerate command pass the same--limit 100, so they stay the same command.Note:
--checkcompares nodes and edges, not weight labels (svgStructure, by design), so CI passes with or without this and never caught the 29.Local: the new
--checkcommand exits 0 ("up to date").