Repository navigation
perf(architecture): ask codegraph once per repeated name - #41
Merged
Merged
Conversation
Same-named symbols sent identical callees probes (and identical node -f probes for a repeated name+file on npm). probeFileEdges now memoizes run for names that occur more than once, keyed by the full args, so each distinct question is asked once. Single-occurrence names are not cached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up (b) from #39's review.
N same-named symbols ran N identical
calleesprobes, plus identicalnode -fprobes on npm when a name repeated within a file.probeFileEdgesnow wrapsruninmemoizeRepeatedNames: for a name that occurs more than once, the answer is cached under the full args, socalleesis asked once per name andnode -fonce per name+file. Names that occur once go straight through, so memory holds only answers that are read again.No output change: every symbol reads the same answer it would have fetched.
New test: three
runs across two files plus onesolosymbol → 4 codegraph calls (was 6), with the same edges and unresolved names.Local:
node test/run.js176 passed, 0 failed (fork codegraph).