Repository navigation
Conversation
5 of 13 tasks
7 of 13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
fetch_entitlements(exclude_ended=True)passes a Pythonboolinto yarl query params and raisesTypeError. Coerceexclude_endedwithint(...)when it is notNone, matching how other Discord query bools are handled in this codebase.Changes
EntitlementRequests.get_entitlements, sendexclude_endedas0/1instead of a raw boolRelated Issues
Fixes #1827
Test Scenarios
get_entitlementswithexclude_ended=True/Falseand confirm the request query uses1/0(yarl accepts the values; a raw bool still raisesTypeError)Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files