Repository navigation
hermes: remove unsupported experimental tool timelines - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Released Hermes rejects the experimental timeline bridge's deprecated TurnRunner import, and current Hermes rejects its runtime method overrides. Remove unsupported timeline machinery and the experimental Working switch. Ordinary typing, optional processing reactions, replies, quiet defaults and explicit native display choices remain. The retired activity flag warns and is ignored.
Installer/package inventory cleanup and native display/processing regressions are included. Two separately scoped CI prerequisites clear baseline blockers: remove one redundant GetChatsResult fixture default, and reuse Grid's exact Sharp 0.35.5 security repair for GHSA-wq5f-xc86-pv6w. The dependency commit changes only the server pin and Sharp-family lock entries; its stable patch ID matches e41f608. No Grid feature, other Hermes proposal or workflow bypass is included.
Validation on head646775ca1: integration workflow and full server validation pass; isolated registry build/type/lint, 85 tests across 11 files, exact tracked bundle parity, normal npm/source admission and processing/display/typing/reply/reaction checks across four Hermes hosts, both Umbrel architectures, Rust validation and Linux CLI builds. Server ARM64/Linux image and runtime checks pass. Hosted archive2e077379b74ae7d52707f1b576ffcd8ba7133f7a74ecf0dd58bde47aee5b29ac matches all native installation receipts. Scanners remain unmodified and enabled. All Apple checks also pass, including four main Swift packages and unsigned macOS/iOS device Debug/Release builds. All reported checks are completed with accepted outcomes before linear integration.
Astra xhigh reviewed the removal, native harness, each prerequisite and final exact 16-path combined scope. Native loading uses offline transport and deterministic reply fixtures; provider/customer/device acceptance, adapter publication and server deployment remain separate.