Repository navigation
fix: fix stale typescript definitions - #579
Merged
Merged
Conversation
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsDockerfile:12 DL3066 info: Non-numeric user-id may not be resolvable by host system
Dockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>` |
The sponsored field was left in the type declaration when voucher support was removed (#511), but the implementation only returns volume and total.
fetchRequestOrderbook resolves with request orders, not workerpool orders.
The beneficiary filter is supported by the implementation but was not declared.
The positional address argument was removed, the examples now pass an options object.
obsDeal emits tasksCount and failedTasksCount, not taskCount and failedTaksCount.
obsDeal emits tasks as an object indexed by position in the deal, and idx is a string until the task is initialized.
show resolves tasks as an array of task ids, the first item being the task at index botFirst.
The deal returned by the PoCo viewDeal method includes the sponsor address.
The task returned by the PoCo viewTask method includes timeref.
When the task is not initialized and a dealid is specified, obsTask emits only taskid, dealid, status, statusName and taskTimedOut.
deposit and withdraw resolve the amount as a nRLC decimal string, not as a BN.
checkAllowance always resolves a BN.
sweep does not throw when the native token transfer fails, transaction hashes may be missing and failures are reported in errors.
The id of the resource is exposed as objectId, objId was never set.
…t signatures Both methods take no argument and fetchTokenContract is always defined.
Amounts with units are not supported by formatEth and formatRLC, they throw on unit strings.
parseEth defaults to ether and parseRLC defaults to RLC, both accept numbers.
Every module exposes the sdk version.
showCategory resolves workClockTimeRef as a BN.
Since TDX is the default tag, tee and tdx tags are always added to the orders tag on creation and signing.
prepareDatasetBulk resolves the bulk CID as cid, not bulkCid.
There is a single Secret Management Service since multi SMS support was removed.
The workerpool API url is fetched from Compass, not from the blockchain.
These methods do not return a more() method, page and pageSize options must be used instead.
PierreJeanjacquot
force-pushed
the
fix/ts
branch
from
October 15, 2026 09:29
4e4e7b9 to
2799a73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.