Skip to content

Remove x64 exception handling code and support aarch64 - #562

Open
syntactically wants to merge 6 commits into
mainfrom
lm/aarch64
Open

Remove x64 exception handling code and support aarch64#562
syntactically wants to merge 6 commits into
mainfrom
lm/aarch64

Conversation

@syntactically

@syntactically syntactically commented Oct 20, 2026

Copy link
Copy Markdown
Member

No description provided.

@syntactically syntactically added the kind/enhancement New feature or request label Oct 20, 2026
@syntactically
syntactically added this pull request to stack #563 October 20, 2026 00:42
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from f1bc9ae to 3975edd Compare October 20, 2026 00:56
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from 5a2b052 to a43136d Compare October 20, 2026 17:24
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from 8c0eed1 to f3e17b7 Compare October 20, 2026 19:08
jsturtevant
jsturtevant reviewed Oct 20, 2026
View reviewed changes
Comment thread src/hyperlight_wasm_runtime/src/platform.rs Resolved
jsturtevant
jsturtevant reviewed Oct 20, 2026
View reviewed changes
Comment thread src/hyperlight_wasm_runtime/src/platform.rs Resolved
jsturtevant
jsturtevant reviewed Oct 20, 2026
View reviewed changes
Comment thread src/hyperlight_wasm_runtime/src/platform.rs Resolved
jsturtevant
jsturtevant reviewed Oct 20, 2026
View reviewed changes
Comment thread src/hyperlight_wasm_runtime/src/component.rs Resolved
@jsturtevant jsturtevant mentioned this pull request Oct 21, 2026
Draft
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from 47cfe5c to 76ce45d Compare October 21, 2026 18:45
@syntactically
[dev] Enable building wasm examples on aarch64
5cfba39 
This requires changing the wasi-sdk builder container
definition/script a little bit to make sure it works on aarch64 as
well as x86_64.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
[hyperlight_wasm_aot] Support aarch64-unknown-none
98cba7d 
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
syntactically force-pushed the lm/aarch64 branch 5 times, most recently from 87e2264 to 8ebab69 Compare October 21, 2026 19:29
Base automatically changed from lm/hl-0.18.0 to main October 21, 2026 19:47
@syntactically
syntactically force-pushed the lm/aarch64 branch 4 times, most recently from d2c6ee7 to 5213f3b Compare October 22, 2026 14:45
jsturtevant
jsturtevant previously approved these changes Oct 23, 2026
View reviewed changes

@jsturtevant jsturtevant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like ci still needs some work but over all this LGTM

@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from 1952f4d to fd74970 Compare October 27, 2026 16:42
@syntactically
Remove x86-64-specific exception handling
4afce70 
As of Hyperlight 0.18.0, all of the functionality we need is
supported(ish) with architecture-independent interfaces in core
Hyperlight. Remove the old architecture-specific code in favour of
those new interfaces.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
Move x64/ directory to build/
a7478f6 
Not all guests are x64 anymore.

Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
syntactically force-pushed the lm/aarch64 branch 10 times, most recently from a3181ae to 8138734 Compare November 3, 2026 15:29
@syntactically
syntactically force-pushed the lm/aarch64 branch 2 times, most recently from b5a0428 to b2f884a Compare November 4, 2026 16:40
@syntactically
Support building on aarch64
073b101 
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
@syntactically
[ci] Bump hyperlight common CI setup workflow
e41caf1 
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
ludfjig
ludfjig requested changes Nov 5, 2026
View reviewed changes

@ludfjig ludfjig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but ai had some comments

Comment thread src/hyperlight_wasm/scripts/build-wasm-examples.sh
fi

if [ -f "/.dockerenv" ] || grep -q docker /proc/1/cgroup; then
if [[ "$CI" == "true" && "$RUNNER_ARCH" == "ARM64" && -z "${CI_BUILD_WASM_MODULES:-}" ]]; then

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use ${CI:-} and ${RUNNER_ARCH:-} here? With nounset, this exits when CI is unset, or when CI=true and RUNNER_ARCH is unset. GitHub Actions sets both, but local shells need not.

Comment thread .github/workflows/dep_build_wasm_examples.yml
build-wasm-examples:
merge-docker-image:
needs: build-docker-image
if: ${{ needs.build-docker-image.outputs.do_push }}

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you emit true in the writable branch and compare this output with 'true'? Both branches currently emit the string false, which is truthy here. Fork and Dependabot runs would attempt a registry push.

Comment thread .github/workflows/dep_build_wasm_examples.yml
uses: actions/upload-artifact@v4
with:
name: guest-modules-${{ matrix.wasmtime_version.name }}
name: guest-modules-${{ matrix.arch.name }}-${{ matrix.wasmtime_version.name }}

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the release workflow to download guest-modules-X64-lts into build/${{ env.CONFIG }}? It still requests guest-modules-lts, which this job does not produce.

Comment thread src/hyperlight_wasm_runtime/src/platform.rs
ptr: *const u8,
len: usize,
) -> core::result::Result<(), wasmtime::Error> {
wasmtime_mprotect(ptr as *mut u8, len, WASMTIME_PROT_READ | WASMTIME_PROT_EXEC);

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add instruction-cache synchronization here for ARM processors that need it? Hyperlight's paging barriers only synchronize translations. Wasmtime assigns cache coherence to this hook.

Comment thread .github/workflows/dep_rust.yml
|| matrix.hypervisor == 'hyperv'
&& format('["self-hosted", "Windows", "ARM64", "1ES.Pool=hl-windows-arm", "JobId=build-{0}-{1}-{2}-{3}"]',
matrix.config,
matrix.run_id,

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use github.run_* in both ARM Windows labels? These fields are not defined in matrix and expand to empty strings. Including matrix.wasmtime in the build ID and using the benchmark prefix would also distinguish the jobs.

Comment thread src/tests/c_guests/wasmsamples/dockerfile
&& apt-get install -y g++-multilib \
&& apt-get install -y libgcc-${GCC_VERSION}-dev \
&& apt-get install -y lib32gcc-${GCC_VERSION}-dev
&& ([[ $TARGETPLATFORM == "linux/amd64" ]] \

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a POSIX if here and restore the package name lib32gcc-${GCC_VERSION}-dev? Ubuntu's /bin/sh rejects [[, and || true hides the failure. If these packages are unused, could we remove the branch?

Comment thread Justfile

clippy target=default-target: (check target)
cargo clippy --workspace --exclude hyperlight-wasm-runtime --exclude hyperlight-wasm-macro --profile={{ if target == "debug" {"dev"} else { target } }} --all-targets --all-features -- -D warnings
cargo clippy --workspace --exclude hyperlight-wasm-runtime --exclude hyperlight-wasm-macro --profile={{ if target == "debug" {"dev"} else { target } }} --all-targets --features "$(cargo metadata --format-version 1 --no-deps | jq -r '[.packages[]|.name as$pkg|.features|keys.[]|select(.!="default" and (IN($ARGS.positional[0]//" "|split(",")[])|not))|$pkg+"/"+.]|join(",")' --args {{clippy-excluded-features}})" -- -D warnings

@ludfjig ludfjig Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use keys[] here? jq 1.6 rejects keys.[], leaving the feature list empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludfjig ludfjig ludfjig requested changes
@jsturtevant jsturtevant jsturtevant approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

kind/enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@syntactically @jsturtevant @ludfjig