Repository navigation
Validate device readiness on KVM and MSHV runners - #24
Open
simongdavies wants to merge 1 commit into
Open
simongdavies wants to merge 1 commit into
simongdavies wants to merge 1 commit into
Conversation
Exercise live readiness on hosted KVM and the Azure Linux MSHV AMD and Intel pools as part of PR validation. Keep host device permissions unchanged and require an actual passing live test. Refs #22. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 38aaadb6-fb9d-4ecd-809f-e996b2f8c463 Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Privileged execution of PR-built binaries on organization-wide self-hosted pools requires maintainer confirmation of runner isolation, repository access, and successful live runs.
No open issues 🎉
What changed in this PR
This PR adds live device-readiness validation for hosted KVM and Azure Linux MSHV AMD and Intel runners, addressing the validation requested in #22.
Changes:
- Moves readiness and recovery race tests into a three-entry hypervisor matrix.
- Adds an opt-in KVM live test and requires an explicit live-test pass, running the test binary as root without changing device permissions.
- Documents validation coverage, host diagnostics, and limitations.
| File | Description |
|---|---|
| docs/architecture.md | Documents the runner matrix, live checks, and validation boundaries. |
| device-plugin/probe_kvm_linux_test.go | Adds an opt-in live KVM test using the production readiness helper. |
| .github/workflows/pr-validation.yml | Adds readiness jobs for KVM and both MSHV pools, with host diagnostics and explicit pass verification. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise live readiness on hosted KVM and the Azure Linux MSHV AMD and Intel pools as part of PR validation. Keep host device permissions unchanged and require an actual passing live test.
Refs #22.