Repository navigation
fix: preserve integer enum and const values in type errors - #288
Merged
jdesrosiers merged 2 commits intoOct 12, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jdesrosiers
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #287
Schemas combining
type: "integer"with integer enum or const values incorrectly reported“A value is not allowed here” when validation failed. For example,
enum: [1, 2]nowcorrectly reports “Expected one of 1 or 2”.
Use a shared type-compatibility predicate for enum and const filtering, checking
serialized numeric values with
Number.isInteger. Preserve existing number/stringbehavior, message formatting, and schema-location attribution.
Add 14 regression fixtures covering integers, fractions, union types, negative values,
zero, exponential notation, incompatible types, successful validation, and nested
locations through both public API paths.
Validation:
Environment note: Vitest warned that Node 25 is outside its supported engine range; all
checks completed successfully.