Repository navigation
fix: make install.ps1 fail closed on checksums - #18
Merged
Merged
Conversation
install.ps1 installed whatever it downloaded when the sums file was missing, did not name the asset or could not be fetched. It now refuses, the way install.sh does. - looks for macbash-windows-<arch>.sha256 first (what Cross-build publishes), then checksums.sha256, and matches the asset name exactly, case included - a missing sums file, a sums file without the asset, a malformed or duplicate entry, a mismatch or a download error throws and installs nothing - tests/install_ps1.rs runs the rendered script under pwsh against a loopback host, and skips when pwsh is not on PATH - the loopback server and which() move from tests/install_sh.rs into tests/common so both installer tests share them - .hyperi-ci.yaml sets build.rust.optimize.allocator: system, since Cargo.toml declares no jemalloc feature and every build warned and fell back - packaging/README.md: macOS and Windows builds ship - docs/release.md and the cross-build.yml header: the tag push does start Cross-build, because the tag sits on the released commit and the skip-ci mark is on the chore commit after it
catinspace-au
force-pushed
the
fix/ps1-fail-closed
branch
from
October 14, 2026 05:32
8676403 to
95975f4
Compare
|
Released in v1.5.12 -- https://github.com/hyperi-io/macbash/releases/tag/v1.5.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.ps1 still carried
catch { # checksums file is optional }, so it installed an unverified binary whenever the sums file was missing or did not name the asset. install.sh stopped doing that in #16. This brings the Windows installer into line and picks up the other follow-ups.macbash-windows-<arch>.sha256first (Cross-build writes it without the.exe), thenchecksums.sha256, exact asset name, case included.hyperi-ci.yaml:build.rust.optimize.allocator: systemclears the "jemalloc feature not declared" warning, since Cargo.toml has no jemalloc feature and this is a short-lived CLI[skip ci]stops the tag push starting Cross-build. It does not. v1.5.11 got apushrun (38499786588) because the tag points at 3d39ab9, and the[skip ci]is on the chore commit after itNot covered: Windows PowerShell 5.1 and a real Windows host. Tested on pwsh 7.6.6 on Linux.