Repository navigation
feat: name the column and the cell text when a row is too tall for the page - #50
Merged
Merged
Conversation
…e page The row-overflow message now names the column holding the row's tallest cell and quotes the first 40 characters of that cell (line breaks as spaces, an ellipsis after a longer text), as the width messages already name the column. The error has class writetfl_error_row_too_tall and the overflow_action = "warn" warning writetfl_warning_row_too_tall. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… edge cases The cell prefix goes through the same formatting the table is drawn with, so a missing cell reads as the table's na_string and a list cell as it is drawn. The troubleshooting vignette shows the new message, and tests pin ties, multibyte text, line breaks at the limit, factors, list cells and that the width-overflow conditions carry no row-too-tall class. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #44
Summary
na_string), with line breaks shown as spaces and "..." after a longer text, so the row can be found in a deeply nested table. The width messages already named the column. This resolves writetfl issue 44 ("When data cannot fit onto the page, give a clear indication of what data causes it").writetfl_error_row_too_tall; underoverflow_action = "warn"the warning has classwritetfl_warning_row_too_tallwith the same message.paginate_rows()gains anna_stringargument for the formatting.design/DECISIONS.mdand a line underpaginate_rows()indesign/ARCHITECTURE.md; the troubleshooting vignette shows the new message.Tests
na_stringvalues, factors, list cells, and equality with the drawn cell text).export_tfl()of a table with one long cell on a short page errors, and warns underoverflow_action = "warn", with the row, the column name and the text prefix in the message and the new classes; the width-overflow conditions keep no class.paginate_rows()picks the tallest wrap-eligible column of the overflowing row even when a wrap-ineligible column is taller.🤖 Generated with Claude Code