Repository navigation
Warnings from choosing a group's intervals name the group - #716
Open
billdenney wants to merge 14 commits into
Open
billdenney wants to merge 14 commits into
billdenney wants to merge 14 commits into
Conversation
PKNCAdata() gives the dose regimen warnings of each group once, prefixed with the group, but the other warnings raised while choosing that group's intervals passed through without it: pknca_warning_no_tau_for_intervals, pknca_warning_no_dose_times_for_group, and pknca_warning_multiple_dose_routes. Interval selection now gathers every warning with a pknca_warning_* class, so these name the group too. The calculation in pk.nca(), which shares the collector, still gathers only the dose regimen warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PKNCAdata()prefixes each group's dose regimen warnings with the group ("subject=1: ..."), but other warnings raised while choosing that group's intervals did not say which group they were about:pknca_warning_no_tau_for_intervals,pknca_warning_no_dose_times_for_group(a subject with concentrations but no doses), andpknca_warning_multiple_dose_routes. Repro: doses at 0, 5, and 17 give "The dosing interval could not be determined from the dose times, ..." with no group.Fix
Interval generation now gathers every
pknca_warning_*warning in the group collector (prefixed, once per group).pk.nca(), which shares the collector, still gathers only dose regimen warnings.Tests
Exact prefixed messages for all three warnings through
PKNCAdata(), and a unit test that only interval selection gathers non-regimen PKNCA warnings while base warnings pass through unchanged.Stacked on
fix/interval-add-param-start-end; this PR's diff is only this fix.🤖 Generated with Claude Code