Skip to content

Warnings from choosing a group's intervals name the group - #716

Open
billdenney wants to merge 14 commits into
fix/interval-add-param-start-endfrom
fix/no-tau-warning-group
Open

billdenney wants to merge 14 commits into
fix/interval-add-param-start-endfrom
fix/no-tau-warning-group

Conversation

@billdenney

Copy link
Copy Markdown
Member

PKNCAdata() prefixes each group's dose regimen warnings with the group ("subject=1: ..."), but other warnings raised while choosing that group's intervals did not say which group they were about: pknca_warning_no_tau_for_intervals, pknca_warning_no_dose_times_for_group (a subject with concentrations but no doses), and pknca_warning_multiple_dose_routes. Repro: doses at 0, 5, and 17 give "The dosing interval could not be determined from the dose times, ..." with no group.

Fix

Interval generation now gathers every pknca_warning_* warning in the group collector (prefixed, once per group). pk.nca(), which shares the collector, still gathers only dose regimen warnings.

Tests

Exact prefixed messages for all three warnings through PKNCAdata(), and a unit test that only interval selection gathers non-regimen PKNCA warnings while base warnings pass through unchanged.

Stacked on fix/interval-add-param-start-end; this PR's diff is only this fix.

🤖 Generated with Claude Code

billdenney and others added 14 commits November 9, 2026 18:41
PKNCAdata() gives the dose regimen warnings of each group once, prefixed
with the group, but the other warnings raised while choosing that group's
intervals passed through without it:  pknca_warning_no_tau_for_intervals,
pknca_warning_no_dose_times_for_group, and
pknca_warning_multiple_dose_routes.  Interval selection now gathers every
warning with a pknca_warning_* class, so these name the group too.  The
calculation in pk.nca(), which shares the collector, still gathers only the
dose regimen warnings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@billdenney
billdenney added this pull request to stack #717 November 13, 2026 18:08

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant