Repository navigation
Interval editing helpers reject arguments they do not take - #715
Open
billdenney wants to merge 14 commits into
Open
billdenney wants to merge 14 commits into
billdenney wants to merge 14 commits into
Conversation
interval_add_param(start = , end = ) and the other interval editing helpers took `...` only to share their generic's signature, so `start` and `end` were silently dropped and the edit applied to every interval. Every method of interval_add_param(), interval_remove_param(), interval_add_impute(), interval_remove_impute(), and interval_add_secondary() now stops with pknca_error_unknown_argument for anything in `...`, and the message for `start` or `end` points at `target_groups = data.frame(start = , end = )`, which already selects intervals by time and is now documented as doing so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-add-param-start-end # Conflicts: # tests/testthat/test-secondary-parameters.R
…-add-param-start-end
…-add-param-start-end
…-add-param-start-end
…-add-param-start-end
…-add-param-start-end
…-add-param-start-end
…m-start-end Both sides added to tests/testthat/test-secondary-parameters.R; both are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The merge of fix/interval-add-secondary-generated kept both sides of test-secondary-parameters.R, which brought back the tests of the reverted clr.*.dn calculation; only this branch's own test is added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-add-param-start-end
…-add-param-start-end
…-add-param-start-end
…-add-param-start-end
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interval_add_param(intervals, "auclast", start = 0, end = 12)addedauclastto every interval:startandendfell into..., documented as ignored. The same held forinterval_remove_param(),interval_add_impute(),interval_remove_impute(), andinterval_add_secondary().Fix
Every method of those five generics now stops with
pknca_error_unknown_argumentfor anything in.... Forstart/endthe message points attarget_groups = data.frame(start = , end = ), which already selects intervals by time and is now documented as doing so. This is a behaviour change for code that passed extra arguments, which were silently ignored before.Tests
Each helper (data.frame and PKNCAdata methods) errors for
start/endwith the hint; other named or unnamed extras error without it;target_groupswithstart/endrestricts the edit.Stacked on
fix/interval-add-secondary-generated; this PR's diff is only this fix.🤖 Generated with Claude Code