Skip to content

data-raw: replace stamp-file download with archive-listing lookup - #2

Merged
billdenney merged 1 commit into
mainfrom
fix/nci-stamp-403-fallback
Sep 30, 2026
Merged

billdenney merged 1 commit into
mainfrom
fix/nci-stamp-403-fallback

Conversation

@billdenney

Copy link
Copy Markdown
Member

The NCI EVS Publication Date Stamp URLs returned HTTP 403 from GitHub Actions (IP-blocked) while being accessible from other environments. Replace fetch_current_release_date() with a simpler implementation that calls list_archive_dates() and takes the maximum date — the archive already contains a dated file for every published release, so the max archive date always equals the current release date.

Also switch fetch_ct_sdtm.R and fetch_ct_adam.R to always use archive_url() for downloading terminology files, since the current release is now derived from the archive listing rather than the undated SDTM_CURRENT / ADAM_CURRENT URLs. This removes all dependency on the Publication Date Stamp files.

The NCI EVS Publication Date Stamp URLs returned HTTP 403 from GitHub
Actions (IP-blocked) while being accessible from other environments.
Replace fetch_current_release_date() with a simpler implementation that
calls list_archive_dates() and takes the maximum date — the archive
already contains a dated file for every published release, so the max
archive date always equals the current release date.

Also switch fetch_ct_sdtm.R and fetch_ct_adam.R to always use
archive_url() for downloading terminology files, since the current
release is now derived from the archive listing rather than the undated
SDTM_CURRENT / ADAM_CURRENT URLs. This removes all dependency on the
Publication Date Stamp files.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@billdenney
billdenney merged commit 8545544 into main Sep 30, 2026
9 checks passed
@billdenney
billdenney deleted the fix/nci-stamp-403-fallback branch September 30, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant