Repository navigation
data-raw: replace stamp-file download with archive-listing lookup - #2
Merged
Merged
Conversation
The NCI EVS Publication Date Stamp URLs returned HTTP 403 from GitHub Actions (IP-blocked) while being accessible from other environments. Replace fetch_current_release_date() with a simpler implementation that calls list_archive_dates() and takes the maximum date — the archive already contains a dated file for every published release, so the max archive date always equals the current release date. Also switch fetch_ct_sdtm.R and fetch_ct_adam.R to always use archive_url() for downloading terminology files, since the current release is now derived from the archive listing rather than the undated SDTM_CURRENT / ADAM_CURRENT URLs. This removes all dependency on the Publication Date Stamp files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NCI EVS Publication Date Stamp URLs returned HTTP 403 from GitHub Actions (IP-blocked) while being accessible from other environments. Replace fetch_current_release_date() with a simpler implementation that calls list_archive_dates() and takes the maximum date — the archive already contains a dated file for every published release, so the max archive date always equals the current release date.
Also switch fetch_ct_sdtm.R and fetch_ct_adam.R to always use archive_url() for downloading terminology files, since the current release is now derived from the archive listing rather than the undated SDTM_CURRENT / ADAM_CURRENT URLs. This removes all dependency on the Publication Date Stamp files.