Conversation
…ance.is_conditional TangentialClassifierFreeGuidance.is_conditional reads self._num_outputs_prepared, which is not defined anywhere in the class or base class. The correct attribute name is self._count_prepared, which is set in BaseGuidance.__init__ and incremented in prepare_inputs. All other guiders use this correct attribute. This bug causes AttributeError when accessing is_conditional (and by extension is_unconditional, which is defined as not self.is_conditional). Fixes huggingface#14794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ance.is_conditional
TangentialClassifierFreeGuidance.is_conditional reads self._num_outputs_prepared, which is not defined anywhere in the class or base class. The correct attribute name is self._count_prepared, which is set in BaseGuidance.init and incremented in prepare_inputs. All other guiders use this correct attribute.
This bug causes AttributeError when accessing is_conditional (and by extension is_unconditional, which is defined as not self.is_conditional).
Fixes #14794
What does this PR do?
Fixes # (issue)
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.