Repository navigation
Conversation
Collaborator
Author
|
The pytest failure is the one on main that hotosm/openaerialmap#369 fixes (test_legacy_result_with_a_bare_user_id); this PR does not touch that test. I’ll rebase once hotosm/openaerialmap#369 is merged. |
This was referenced Oct 27, 2026
Add oam:owner_id to the OAM extension (v0.4.0), next to the immutable oam:uploader_id: the owner changes when imagery is transferred, the uploader does not. create_item writes it when set, and the legacy sync gives legacy Items their oam-legacy|<id> account as owner until claimed. This is the field proposed in ADR 0011. The uploader does not set it yet. Signed-off-by: Julian Somoza <julian.somoza@gmail.com>
Items are public, so stactools-hotosm stopped writing oam:uploader_email in #343, but v0.3.0 was already released and kept the field. v0.4.0 is not released yet, so drop it there. The schema rejects unknown oam: fields, so v0.4.0 Items cannot carry an email; Items on v0.3.0 still validate against v0.3.0. Signed-off-by: Julian Somoza <julian.somoza@gmail.com>
somoza
force-pushed
the
feat/stac-owner-id
branch
from
October 30, 2026 10:43
9912469 to
3a5c6ea
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
oam:owner_idto the OAM extension (v0.4.0), the field proposed in ADR 0011, and dropsoam:uploader_emailfrom that new version.Depends on:
docs/dev/ingest/schema.mdlinks to it.main. Until it merges, CI fails ontest_legacy_result_with_a_bare_user_id, which this PR does not touch.What type of PR is this? (check all applicable)
Related Issue
Part of #332. Implements the field from ADR 0011 (#370).
Describe this PR
oam:owner_id(OAM extension v0.4.0). The current owner of the imagery, asprovider|id, next tooam:uploader_id. The uploader never changes; the owner changes when imagery is transferred.create_itemwrites it when set, and the legacy sync gives legacy Items theiroam-legacy|<id>account as owner until it is claimed. The uploader does not set it yet; that comes in a follow-up PR.No organisation prefix yet. ADR 0011 proposes
hotosm-org|<id>for organisations, but that prefix is still to be agreed with the HOT Login team. Released schemas cannot change, so the v0.4.0 description only names the prefixes in use today (hotosm|,oam-legacy|). The field's pattern accepts anyprovider|id, so organisations need no new schema version.Drop
oam:uploader_emailfrom v0.4.0. #343 stopped writing it because Items are public, but v0.3.0 was already released and kept the field. v0.4.0 is not released yet, so this is the moment to drop it. The schema rejects unknownoam:fields, so a v0.4.0 Item cannot carry an email. Items on v0.3.0 still validate against v0.3.0. The owner backfill, which moves stored Items to v0.4.0, will have to remove the field from Items registered before #343.Schema housekeeping. Symlinks for the published docs site and the bundled package schema, the v0.4.0 checksum in
RELEASED_SCHEMA_SHA256, both CHANGELOGs, anddocs/dev/ingest/schema.md.After merge, new Items point to v0.4.0, with no owner until the uploader sets it.
Screenshots
N/A, no UI change.
Alternative Approaches Considered
Reusing
oam:uploader_idas the owner, or keeping ownership only in the uploader database. Both are covered in ADR 0011.For
oam:uploader_email, keeping it in v0.4.0 as an unused optional field. Dropping it now means no new Item can publish an email again.Review Guide
tests/test_owner_identity.pycovers the owner on Items and in the legacy sync.test_v0_4_0_drops_uploader_emailchecks that v0.4.0 rejects the email while a v0.3.0 Item still accepts it.Question for reviewers: is dropping
oam:uploader_emailin v0.4.0 fine, or would you rather keep it until a later version?AI Tool Usage
How much of this PR was AI-assisted? (check one)
If an AI agent is filling this in: declare the level honestly, and open as a draft if it is 5. Do not lower the declared level to get the PR reviewed.
If level 1 or above:
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?