Repository navigation
Conversation
This was referenced Oct 2, 2026
Author
|
Withdrawing this PR because the reported Windows failure was caused by a Puppeteer browser-launcher regression and is resolved by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, forcibly stopping a Node process that initialized
highcharts-export-server@6.0.0can leavechrome-headless-shell.exerunning after Node has exited. The leftover browser consumes resources and may keep its user data directory in use, interfering with a later exporter launch using the same directory.The reproduction is to initialize the exporter, forcibly stop its Node PID with
Stop-Process -Id <pid> -Force, and check whether the Chrome PID remains. The export server's graceful cleanup cannot run after a forced termination. In our local comparison, Chrome survived with WebSocket transport and exited with its Node owner when Puppeteer's pipe transport was enabled.The export server currently provides no normal configuration option for that transport. Passing
pipethrough its debug options also requires enabling browser debug mode and adjusting unrelated launch settings.This PR lets applications opt into pipe transport with
puppeteer.pipeorPUPPETEER_PIPE, while keeping the defaultfalse. It forwards the option to Puppeteer and rebuilds the checked-in ESM and CommonJS bundles through the existing package entry points. The README and sample environment file document the setting and the README explains its incompatibility with a nonzero debugging port.Validation with Node 24.15.0:
npm run buildpassed.npm run unit:test -- --runInBandpassed all 58 tests across 6 suites.masterproduced the same two warnings.PUPPETEER_PIPE=true; an explicit module setting could override it.Validation with Node 22.22.2:
require(ESM)support for a jsdom dependency requires Node 24.9 or newer.masterat9675410d14aaa6dd2009b244262cf637040f3d93, using the same locked dependencies. Its other five suites passed all 45 tests.Fixes #687