Repository navigation
Conversation
| This e2e packs a layout into an MSIX and an APPX package with `msix_package`, from an external repository. | ||
| It unpacks both packages with makemsix and verifies that their content matches the layout byte for byte. | ||
|
|
||
| The `app` files are not a real application: `app.exe` holds every byte value, `readme.txt` has CRLF line endings. |
Member
There was a problem hiding this comment.
What does "app.exe holds every byte value" mean?
| - inputs are only read, their permissions and timestamps are never modified, and the package does not record file permissions | ||
| - the layout must not contain symlinked directories, makemsix fails on them | ||
| - a source directory is packaged with everything it contains on disk, prefer a tree artifact | ||
| - packages are not reproducible: makemsix stamps entries with the current time, and orders them by the modification time of the layout files |
Member
There was a problem hiding this comment.
Is there a way to address that easily?
| - the layout must not contain symlinked directories, makemsix fails on them | ||
| - a source directory is packaged with everything it contains on disk, prefer a tree artifact | ||
| - packages are not reproducible: makemsix stamps entries with the current time, and orders them by the modification time of the layout files | ||
| - packages are not signed, sign them with `signtool` before installing them |
Member
There was a problem hiding this comment.
Could we provide that cross-platform?
| Notes: | ||
|
|
||
| - inputs are only read, their permissions and timestamps are never modified, and the package does not record file permissions | ||
| - the layout must not contain symlinked directories, makemsix fails on them |
Member
There was a problem hiding this comment.
Should we add a nice failure message about it, or is makemsix clear when failing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After porting msix_packaging to BCR, I'm adding a rule to
windows_supportfor convenience, as discussed with @ArchangelX360:This rule can pack a
layout_dirto the.msix/.appxarchive. It usesllvmunder the hood and hermetic.Feature notes:
msix-packagingimplementation). I plan to explore it further in the future.appbundlesuppport yet.