Repository navigation
Conversation
submit_ratings() for ranking rounds refused ballots that mix completed and open tasks, but compared the status with 'complete' instead of 'completed', so the check has never run (since 2017). Such ballots are legitimate: an entry that is requalified after the juror ranked gets its task reopened, and apply_ranking() completes every task of the ballot. Fixing the typo instead would answer 400 to that juror's ballot, so remove the check and keep the behaviour production has always had. Adds a test: rank, requalify the last entry, resubmit the same ballot. It passes on master and with this change; with the check switched on it fails with a 400. Fixes #676. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #676.
The check meant to refuse ranking ballots that mix completed and open tasks compared with
'complete'instead of'completed', so it never ran. Mixed ballots are legitimate (an entry requalified after the juror ranked gets its task reopened), andapply_ranking()completes every task. Fixing the typo would answer 400 to those ballots, so this removes the check and keeps the current behaviour.Tests
test_ranking_ballot_with_completed_and_open_tasks: rank, requalify the last entry, resubmit the same ballot, and check that no open tasks are left. It passes on master and with this change; with the typo fixed instead (the check switched on) it fails with a 400.Written by Claude (Claude Code) on behalf of @lgelauff.
🤖 Generated with Claude Code