Import Data.Array.ST instead of Data.Array.ST.Safe

[konsumlamm]

Data.Array.ST exports the same things as Data.Array.ST.Safe, the latter was just added as a migration strategy. The *.Safe modules in array might get deprecated in the future, see https://gitlab.haskell.org/ghc/packages/array/-/issues/11.

[treeowl]

There seems to be an incorrect assumption somewhere; CI is failing.

[konsumlamm]

Yes, Data.Array.ST.Safe is marked as Trustworthy, while Data.Array.ST is not. This makes it fail, because Data.Graph is marked as Safe.

The next step would be to mark Data.Array.ST as Trustworthy.

[meooow25]

On Hackage I can see that Data.Array.ST is "Safe-Inferred" 0.5.5.0 onwards. This is included in GHC 9.6. Doesn't that mean it should compile fine without any changes with GHC 9.6 and above?

[meooow25]

Hi @konsumlamm, I'm wondering if we want to finish this.

The next step would be to mark Data.Array.ST as Trustworthy.

Alternately we can just mark Data.Graph as Trustworthy and resolve it here on the containers side. I think that would be fine.

[konsumlamm]

I marked Data.Graph as trustworthy for array < 0.5.7.0 (for array >= 0.5.7.0, it's inferred as safe).

[meooow25]

Thanks! I would be fine with not having the CPP and making it always Trustworthy. Or does GHC complain if that's the case?

[konsumlamm]

Thanks! I would be fine with not having the CPP and making it always Trustworthy. Or does GHC complain if that's the case?

That makes the CI fail due to -Werror, since it's inferred as safe on newer versions.

[meooow25]

Ah that's a bit annoying, let's keep it like this then.

I think you need to mark the PR as non-draft before I can merge it.