Repository navigation
fix(release): the v0.3.8 publish blockers — the scanner false-positive + the npx regression - #1847
Merged
Merged
Conversation
…bust npx form Open VSX's secret scanner blocked the v0.3.8 publish: the hashicorp-tf-password rule false-positives on 'UNARMED_PASSWORD = "__hub_unarmed__"' (a placeholder sentinel from the unarmed-hub work, entropy 3.17). Renamed to UNARMED_SENTINEL — the scanner's rule keys on *PASSWORD* assignments with quoted literals; the constant's meaning is unchanged (a sentinel, never a credential). The Marketplace step broke earlier: 'sh: 1: vsce: not found' — the runner's npx no longer resolves @vscode/vsce's bin via the bare package form (worked at v0.3.7, broke since; the runner's npm moved). The robust explicit form: npx --yes --package @vscode/vsce vsce publish.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.8 Marketplace publish failed twice: Open VSX's secret scanner false-positived on the UNARMED_PASSWORD sentinel (renamed UNARMED_SENTINEL — meaning unchanged, never a credential), and the Marketplace loop broke on the runner's npx no longer resolving @vscode/vsce's bin (the explicit --package form). Docs+constant+workflow only. On merge: delete the failed v0.3.8 tag+release (never published anywhere), re-tag alpha.4, promote again.