Repository navigation
fix(app+session-ui): webview string-frame parsing (#1843) + the edit-title row opens the file - #1844
Merged
Merged
Conversation
…discrimination (#1843); the whole edit-title row opens the file Two live-reported fixes from the v0.3.8-alpha exercise: (1) The global event stream was dying on EVERY frame in the webview fetch path: the SDK reader yields raw SSE data lines as STRINGS (the platform path yields parsed objects) — a string frame hit "payload" in event as a TypeError, killing the loop, reconnecting, dying again (the all-day '[global-sdk] event stream failed' in the client telemetry). The loop now parses strings first (parseSseFrame: malformed/non-object lines skip, never kill), narrows with honest type guards (isLegacyWireFrame for the {directory, payload} wrapper, isWireEvent for both wire vocabularies), and the downstream cursor/sync checks read the extracted payload. (2) The edit/write tool part's openable filename was a tiny target (the filename glyph only) — the live report clicked the row (the directory span sits between) and got nothing. The whole title area now opens the file when a path exists (prevent + stopPropagation, same semantics as the filename button). App typecheck exit 0 (the director's pipe lied about the exit code once — re-run clean); session-ui suite 161/0; the app suite's 31 local fails are the documented pre-existing families (13 solid-js/web harness, the i18n/evicted/relay baseline) — CI is the merge gate for this one, and it RUNS before merge.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1843. The global event stream was dead in every webview panel (string SSE frames hitting the
indiscrimination as a TypeError, every frame, all day — the live telemetry error Aaron pasted). Parses + narrows before the discrimination; malformed lines skip. Companion: the edit/write part's whole title row opens the file. Director gates: app typecheck exit 0, session-ui suite 161/0, drift PASS — and this PR's CI RUNS before merge (the stream loop is the most load-bearing code in the app; after three momentum merges today, the discipline returns).