Repository navigation
fix(session-ui): review file rows openable regardless of diff renderability (#1841) - #1842
Merged
Merged
Conversation
…derability (#1841) Live report 2026-10-22: clicking the file rows in session output (the review accordion — 'files next to edit') did nothing at all. Root cause: the row's open-file affordance was gated on diffCanRender() (additions/deletions !== 0) AND the trigger was disabled for the same condition — any file whose live summary carries no line counts rendered a disabled native button with no open affordance inside, a dead row by construction (Kobalte's disabled trigger swallows descendant clicks). Opening a file requires no renderable diff: the affordance renders whenever onViewFile exists; the trigger stays enabled whenever a handler exists (expansion is already a no-op for non-renderable rows via the null Accordion.Item value). Source-assertion tests RED→GREEN per the repo convention; session-ui component suite 161/0.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1841. The second live find from the release exercise: the review-accordion file rows were dead whenever the live summary carried no line counts — the open affordance and the trigger were both diffCanRender-gated. Un-gated (opening a file needs no diff); source-assertion tests RED→GREEN; session-ui suite 161/0; drift PASS. Director-gated (suite + manifest custody); the alpha.3 release build re-gates the full matrix before Marketplace.