Repository navigation
fix(session-ui): file-reference linkification is core, not a layout preference (#1839) - #1840
Merged
Merged
Conversation
…reference — un-gate markInlineCode + markFileLinks (#1839) Live report 2026-10-22: with data-new-layout off in a panel's stored settings, every file path in chat rendered as an inert pill — silently, zero errors, scripts and markdown alike. The pill tagging (markInlineCode, decorate) and the anchor wrapping (markFileLinks, the render effect) were both gated on the new-layout body attribute; the resolver, bridge, and open-file handler all worked and none of it was reachable. Un-gated both, per markExternalLinks' own precedent (#270: bridge-handled links run unconditionally). File links are a capability, not a chrome preference. Source-assertion tests pin the wiring (the repo's component-source-assertion convention) — RED on the gated source, GREEN on the fix; full session-ui component suite 159/0. Found by Aaron exercising the v0.3.8-alpha.1 build — the release exercise doing its job.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live-reported bug from the v0.3.8-alpha.1 exercise: every file link in chat silently inert when a panel's stored layout setting had
data-new-layoutoff. Both stages of the file-ref path were layout-gated — the pill tagging (markInlineCode) and the anchor wrapping (markFileLinks) — while the resolver, route, bridge, and 0.3.8 handler all worked but were unreachable. Un-gated both permarkExternalLinks' own #270 precedent; the cosmetic code-metadata decoration stays gated. Closes #$ISSUE.Gates (director-run)
The debug trail (layer-by-layer probes: route green via frontdoor+direct, bridge present in the deployed dist bundle, telemetry clean, then the one discriminating DOM observation from Aaron) is in the campaign ledger.