Repository navigation
Align OpenAI template behavior across nav and Studio accessibility controls - #2547
Open
groupthinking with Codex wants to merge 2 commits into
Open
groupthinking with Codex wants to merge 2 commits into
groupthinking with Codex wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Codex
AI
changed the title
groupthinking
approved these changes
Nov 2, 2026
groupthinking
marked this pull request as ready for review
November 2, 2026 20:08
Contributor
🔍 PR Validation |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| <div className="template-pane-tabs" role="tablist" aria-label="Studio views"> | ||
| {MOBILE_PANES.map((pane) => ( | ||
| <button key={pane} type="button" role="tab" id={`studio-tab-${pane}`} | ||
| aria-selected={mobilePane === pane} aria-controls={`studio-panel-${pane}`} |
Contributor
There was a problem hiding this comment.
At viewport widths of 900px or less, replacing aria-pressed with aria-selected removes the active-pane highlight because the stylesheet still targets aria-pressed='true'.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The change breaks mobile tab selection styling, exposes resizers whose announced values diverge from fixed pane widths, and removes the page’s only main landmark.
3 open issues
What changed in this PR
This PR advances #2386 by aligning UVAI navigation and Studio controls with the OpenAI Responses starter’s accessibility patterns, without changing pricing or the core product flow.
Changes:
- Adds mobile navigation active-page semantics matching desktop links.
- Adds Studio tab semantics, keyboard resizing, and pane-control accessibility attributes.
- Adds navigation tests and updates Studio interaction tests.
| File | Description |
|---|---|
apps/web/src/components/studio/StudioIdeShell.tsx |
Adds accessible tabs, keyboard splitters, and collapse/restore semantics. |
apps/web/src/components/Nav.tsx |
Adds aria-current to active mobile links. |
apps/web/src/components/__tests__/StudioIdeShell.template.test.tsx |
Updates tab assertions and tests keyboard splitter behavior. |
apps/web/src/components/__tests__/Nav.template.test.tsx |
Adds Home and Pricing active-navigation tests. |
Review effort: Balanced
| if (key === 'ArrowUp') next = current + RESIZE_STEP; | ||
| if (key === 'ArrowDown') next = current - RESIZE_STEP; | ||
| if (next === null) return false; | ||
| update(clampPaneWidth(next)); |
| <div className="template-pane-tabs" role="tablist" aria-label="Studio views"> | ||
| {MOBILE_PANES.map((pane) => ( | ||
| <button key={pane} type="button" role="tab" id={`studio-tab-${pane}`} | ||
| aria-selected={mobilePane === pane} aria-controls={`studio-panel-${pane}`} |
| id="studio-panel-chat" | ||
| data-testid="studio-ide-chat-pane" | ||
| aria-label="Chat" | ||
| role="tabpanel" |
github-actions
Bot
added
javascript
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Linked by repository automation.
Outcome
Home/Pricing navigation and Studio pane controls now match the OpenAI Responses starter interaction model more closely, with responsive pane switching and stronger accessibility semantics. This addresses the template-completeness gap without changing product flow or pricing behavior.
Scope
aria-currentparity with desktop active-state semantics.tablist/tabsemantics with keyboard navigation.aria-controls/aria-expanded.Risk
apps/web/src/components/studio/StudioIdeShell.tsx,apps/web/src/components/Nav.tsx, and related new/updated tests.Verification
List exact automated and manual checks, tied to the current head SHA.
Production evidence
Not yet applicable for this PR body update; runtime evidence should come from preview validation in PR checks.
Agent handoff
Security dependency evidence