Repository navigation
Fail closed on truncated security PR file listings - #2544
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
🔍 PR Validation |
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the stricter security dependency evidence checks.
No open issues 🎉
What changed in this PR
This PR addresses #2415 by strengthening security dependency evidence checks when GitHub’s changed-file listing may be incomplete. It affects PR validation only, leaving dependency review and production runtime unchanged.
Changes:
- Treat missing or non-integer file counts, undersized listings, and listings reaching GitHub’s 3,000-file cap as incomplete.
- Add regression tests for capped listings and missing file-count metadata.
| File | Description |
|---|---|
tests/unit/test_security_dependency_pr_evidence.py |
Extends the test harness and covers capped listings and missing metadata. |
.github/workflows/pr-checks.yml |
Requires security dependency evidence when file-list completeness cannot be established. |
Review effort: Balanced
Canonical issue
Linked through issue automation.
Outcome
Security-marked PRs now require complete security dependency evidence when GitHub may have truncated the changed-file list, preventing hidden dependency changes from bypassing validation.
Scope
Risk
Verification
Production evidence
Not applicable; this changes PR validation only.
Agent handoff
Security dependency evidence