Skip to content

Fail closed on truncated security PR file listings - #2544

Merged
groupthinking merged 4 commits into
mainfrom
copilot/fix-security-pr-checks
Nov 3, 2026
Merged

groupthinking merged 4 commits into
mainfrom
copilot/fix-security-pr-checks

Conversation

Copilot AI commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Canonical issue

Linked through issue automation.

Outcome

Security-marked PRs now require complete security dependency evidence when GitHub may have truncated the changed-file list, preventing hidden dependency changes from bypassing validation.

Scope

  • Included: Treat capped listings and missing or invalid file-count metadata as incomplete.
  • Explicitly excluded: Dependency review behavior and production runtime.
const fileListIncomplete =
  !Number.isInteger(pr.changed_files) ||
  changedFiles.length < pr.changed_files ||
  changedFiles.length >= 3000;

Risk

  • Risk level: low
  • Failure mode: A security-marked PR with an incomplete listing must provide evidence or validation fails.
  • Rollback: Revert the workflow and regression-test changes.

Verification

  • Focused tests
  • Required CI
  • Review threads resolved

Production evidence

Not applicable; this changes PR validation only.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

Security dependency evidence

  • Advisory: N/A — workflow guard change, not advisory remediation
  • Package and versions: N/A
  • Validation: Incomplete file evidence triggers the existing evidence requirement
  • Rollback: Revert the workflow and regression-test changes

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
v0-uvai Ready Ready Preview, v0 Nov 3, 2026 8:25am UTC

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🔍 PR Validation

⚠️ PR title should follow conventional commits format

Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix security PR checks for truncated file evidence Fail closed on truncated security PR file listings Nov 2, 2026
Copilot AI requested a review from groupthinking November 2, 2026 14:57
@groupthinking
groupthinking marked this pull request as ready for review November 2, 2026 20:08
Copilot AI balanced review requested due to automatic review settings November 2, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are reported for the stricter security dependency evidence checks.

No open issues 🎉

What changed in this PR

This PR addresses #2415 by strengthening security dependency evidence checks when GitHub’s changed-file listing may be incomplete. It affects PR validation only, leaving dependency review and production runtime unchanged.

Changes:

  • Treat missing or non-integer file counts, undersized listings, and listings reaching GitHub’s 3,000-file cap as incomplete.
  • Add regression tests for capped listings and missing file-count metadata.
File Description
tests/​unit/​test_security_dependency_pr_evidence.py Extends the test harness and covers capped listings and missing metadata.
.github/​workflows/​pr-checks.yml Requires security dependency evidence when file-list completeness cannot be established.

Review effort: Balanced

@groupthinking
groupthinking enabled auto-merge (squash) November 3, 2026 08:24
@groupthinking
groupthinking merged commit ba55662 into main Nov 3, 2026
26 of 28 checks passed
@groupthinking
groupthinking deleted the copilot/fix-security-pr-checks branch November 3, 2026 08:25

This branch was successfully deployed

1 active deployment
Preview — f5af1041 Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail security PR checks closed when file evidence is truncated

3 participants