Repository navigation
Harden CI lint gates and verify stateless MCP client - #2533
groupthinking with Copilot wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
🔍 PR Validation
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The regenerated workflow adds issues:write and checks:read token permissions that require authorized human review, while hosted compiler/security validation on the exact PR head remains outstanding.
No open issues 🎉
What changed in this PR
This PR strengthens selected CI checks and expands stateless MCP client conformance coverage for EventRelay’s internal tooling. It addresses part of #2455; the broader security audit remains incomplete.
Changes:
- Make selected lint and type-check failures blocking, add package-wide Ruff F821 checks, and document the existing 84.2% coverage floor.
- Pin gh-aw to v1.0.1 and regenerate Repo Assist automation, including permission and runtime safeguards.
- Add stateless MCP
tools/listandtools/callvalidation and update the official conformance runner pin.
| File | Description |
|---|---|
tests/unit/test_official_mcp_conformance.py |
Assert required tool scenarios and the updated conformance pin. |
tests/unit/test_gh_aw_workflow_governance.py |
Check blocking CI gates, coverage documentation, and gh-aw pins. |
tests/testing/official_mcp_auth_client.mjs |
Exercise stateless tool discovery and validate an addition tool response. |
src/youtube_extension/services/agents/monitor.py |
Add a type-checking-only import for the analyzer annotation. |
src/youtube_extension/main.py |
Consolidate URL utility imports. |
scripts/testing/official_mcp_conformance.py |
Pin the published conformance package and require client tool calls. |
.github/workflows/repo-assist.lock.yml |
Regenerate automation with updated runtimes, permissions, and safeguards. |
.github/workflows/README.md |
Document blocking checks, the compiler pin, and the enforced coverage floor. |
.github/workflows/gh-aw-validation.yml |
Validate gh-aw v1.0.1 and its action pins. |
.github/workflows/ci.yml |
Make selected checks blocking and pin Ruff with broader F821 coverage. |
.github/aw/actions-lock.json |
Update gh-aw setup action versions and immutable SHAs. |
Review effort: Balanced
Canonical issue
Outcome
Makes selected CI lint/type-check failures blocking, updates the gh-aw compiler locks, and records official conformance for the stateless MCP client. The broader security audit remains incomplete.
Scope
Risk
issues: writeandchecks: read; review these permission changes before merge. Current dependency scans still report unresolved findings.Verification
Head:
0c5b810c1e51ae6e9a741f7565f1be9ac14c6e00Production evidence
Not applicable: this changes CI, automation locks, and test/conformance code; no production runtime behavior or deployment is claimed.
Agent handoff
Security dependency evidence
@modelcontextprotocol/conformance@0.2.0-alpha.11in the GitHub Advisory Database.0.2.0-alpha.11(source commitc321dd3); gh-awv1.0.1.