Repository navigation
fix(concurrent): reject resizes that cannot reach the runner - #135
Merged
greenhat616 merged 2 commits intoOct 21, 2026
Merged
Conversation
…w its control channel A runner that is still connecting does not read its control channel, yet every split of it queues a `LimitTotal`. The ninth split overflows the eight-slot channel and `resize_runner` panics. Through the real strategy this needs a concurrency above 1024: each quick start round splits connecting runners too, and the runner spawned by the first round receives one limit per later round. The reachable bound is kept as a passing test; the overflow cases are ignored until Phase C.
`RunnerManager::resize_runner` panicked when the runner's control channel was full or closed. A connecting runner does not read its control channel, so splitting it nine times overflowed the channel. The resize now returns `ResizeError::Limit`, and the planner rolls back, so the split is skipped and no runner is spawned for the second half.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4/13 of the event-loop optimization stack · Bug fix. Stacked on part 3.
RunnerManager::resize_runnerreturnsResizeErrorinstead of panicking when the channel is full or closed; the planner rolls back and the split is skipped.